PHP 8.0 | PEAR/FunctionDeclaration: fix handling of constructor property promotion#3343
Merged
gsherwood merged 1 commit intosquizlabs:masterfrom May 27, 2021
Conversation
…rty promotion Adjusts the `PEAR.Functions.FunctionDeclaration` sniff and by extension, the `Squiz.Functions.MultiLineFunctionDeclaration` and the `PSR12.Classes.AnonClassDeclaration` sniffs to handle constructor properties preceded by docblocks correctly. There is one functional change: The sniffs will no longer throw a `FirstParamSpacing` error when there are blank lines between the function open parenthesis and the first parameter. As the sniffs still throw a `EmptyLine` error in that case - and will auto-fix that error - I've deemed that acceptable as the "fixed" file will still be the same. Fixes 3342
This was referenced May 10, 2021
Contributor
Author
|
Thanks for testing @fabianbadoi ! |
gsherwood
added a commit
that referenced
this pull request
May 27, 2021
Member
I think this is completely fine. That message is really there to stop the param starting on the same line as the opening parenthesis, and that's still working perfectly fine. Thanks a lot for fixing this one - it's obviously annoying quite a few people. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts the
PEAR.Functions.FunctionDeclarationsniff and by extension, theSquiz.Functions.MultiLineFunctionDeclarationand thePSR12.Classes.AnonClassDeclarationsniffs to handle constructor properties preceded by docblocks correctly.There is one functional change:
The sniffs will no longer throw a
FirstParamSpacingerror when there are blank lines between the function open parenthesis and the first parameter.As the sniffs still throws an
EmptyLineerror in that case - and will auto-fix that error - I've deemed that acceptable as the "fixed" file will still be the same.Fixes #3342