[PEAR.Commenting.FunctionComment] Add option to disable the check for protected/private function#2815
Merged
gsherwood merged 2 commits intosquizlabs:masterfrom Oct 30, 2020
VincentLanglet:functionComment
Merged
[PEAR.Commenting.FunctionComment] Add option to disable the check for protected/private function#2815gsherwood merged 2 commits intosquizlabs:masterfrom VincentLanglet:functionComment
gsherwood merged 2 commits intosquizlabs:masterfrom
VincentLanglet:functionComment
Conversation
gsherwood
reviewed
Mar 9, 2020
| $ignore = Tokens::$emptyTokens; | ||
| $ignore[] = T_STATIC; | ||
|
|
||
| $scopeModifier = $phpcsFile->findPrevious($ignore, ($stackPtr - 1), null, true); |
Member
There was a problem hiding this comment.
Might be worth using $phpcsFile->getMethodProperties($stackPtr) to gather the method visibility + just check the scope index of the return value, instead of looking for it yourself. Makes a bit more future-proof.
gsherwood
added a commit
that referenced
this pull request
Oct 30, 2020
gsherwood
added a commit
that referenced
this pull request
Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2077