Tokenizer: fix binary cast recognition with inside parentheses whitespace#2215
Merged
gsherwood merged 1 commit intosquizlabs:masterfrom Nov 5, 2018
Merged
Conversation
…pace As reported in my last comment on the original issue 1574, the fix to the tokenizer does not take whitespace inside of the binary cast parentheses into account. This PR fixes this. It also adds a unit test which will guard against regressions to the `Squiz.WhiteSpace.CastSpacing` sniff. As that sniff did not have a `fixed` file, while it _does_ in actual fact contain a fixer, the `.fixed` file has also been added.
This was referenced Nov 2, 2018
Member
|
Thanks a lot. I guess I've coded my type casts the same for so long that I forgot you could have whitespace in there. |
Contributor
Author
|
No worries, I just came across it when I was checking the PHPCS-cross-version compatibility with the token for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in my last comment on the original issue #1574, the fix to the tokenizer does not take whitespace inside of the binary cast parentheses into account.
This PR fixes this.
It also adds a unit test which will guard against regressions to the
Squiz.WhiteSpace.CastSpacingsniff.As that sniff did not have a
fixedfile, while it does in actual fact contain a fixer, the.fixedfile has also been added.