PHP_CodeSniffer_File::findExtendedClassName() works with extended interfaces#1473
PHP_CodeSniffer_File::findExtendedClassName() works with extended interfaces#1473gsherwood merged 1 commit intosquizlabs:masterfrom mhujer:mh-findExtendedClassName
Conversation
|
@mhujer I like it! Thanks. Small suggestion: You may want to adjust the method documentation to make it clear that interfaces will be handled as well. |
|
@jrfnl Thanks for the suggestion, fixed 👍 |
|
Is there anything I can do or improve to get this merged? |
|
Rebased on current master. |
|
@gsherwood Hello, is there something we can do, to improve this, to be included in the next release? Btw do you have any estimates, when do you want to do that release? |
This is scheduled to 3.1.0. The next release will be a bug-fix release, so it will probably be the release after that.
No idea, but I haven't started any of the tasks scheduled for 3.1.0 yet, so it's going to be a while yet. Click the milestone attached to this task to see the list. |
|
Thank you for your response, I was already browsing the milestones, that's why I was asking for estimates and perhaps if there was something blocking this. |
|
Rebased on current master. |
|
Thanks a lot for the contribution, and especially the tests. Easy merge and working well. Sorry it took so long. |
I've changed
PHP_CodeSniffer_File::findExtendedClassName()behaviour so it also works with extended interfaces