Skip to content

PHP_CodeSniffer_File::findExtendedClassName() works with extended interfaces#1473

Merged
gsherwood merged 1 commit intosquizlabs:masterfrom
mhujer:mh-findExtendedClassName
Aug 6, 2017
Merged

PHP_CodeSniffer_File::findExtendedClassName() works with extended interfaces#1473
gsherwood merged 1 commit intosquizlabs:masterfrom
mhujer:mh-findExtendedClassName

Conversation

@mhujer
Copy link
Copy Markdown
Contributor

@mhujer mhujer commented May 16, 2017

I've changed PHP_CodeSniffer_File::findExtendedClassName() behaviour so it also works with extended interfaces

@jrfnl
Copy link
Copy Markdown
Contributor

jrfnl commented May 16, 2017

@mhujer I like it! Thanks.

Small suggestion: You may want to adjust the method documentation to make it clear that interfaces will be handled as well.

@mhujer
Copy link
Copy Markdown
Contributor Author

mhujer commented May 17, 2017

@jrfnl Thanks for the suggestion, fixed 👍

@mhujer
Copy link
Copy Markdown
Contributor Author

mhujer commented Jun 4, 2017

Is there anything I can do or improve to get this merged?

@gsherwood gsherwood added this to the 3.1.0 milestone Jun 13, 2017
@mhujer
Copy link
Copy Markdown
Contributor Author

mhujer commented Jun 23, 2017

Rebased on current master.

@VasekPurchart
Copy link
Copy Markdown
Contributor

@gsherwood Hello, is there something we can do, to improve this, to be included in the next release? Btw do you have any estimates, when do you want to do that release?

@gsherwood
Copy link
Copy Markdown
Member

Hello, is there something we can do, to improve this, to be included in the next release?

This is scheduled to 3.1.0. The next release will be a bug-fix release, so it will probably be the release after that.

Btw do you have any estimates, when do you want to do that release?

No idea, but I haven't started any of the tasks scheduled for 3.1.0 yet, so it's going to be a while yet. Click the milestone attached to this task to see the list.

@VasekPurchart
Copy link
Copy Markdown
Contributor

Thank you for your response, I was already browsing the milestones, that's why I was asking for estimates and perhaps if there was something blocking this.

@mhujer
Copy link
Copy Markdown
Contributor Author

mhujer commented Jul 29, 2017

Rebased on current master.

@gsherwood gsherwood merged commit 504109b into squizlabs:master Aug 6, 2017
gsherwood added a commit that referenced this pull request Aug 6, 2017
@gsherwood
Copy link
Copy Markdown
Member

gsherwood commented Aug 6, 2017

Thanks a lot for the contribution, and especially the tests. Easy merge and working well.

Sorry it took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants