Skip to content

Code Refactoring#91

Closed
Mouhamedtec wants to merge 2 commits intosquare:masterfrom
Mouhamedtec:master
Closed

Code Refactoring#91
Mouhamedtec wants to merge 2 commits intosquare:masterfrom
Mouhamedtec:master

Conversation

@Mouhamedtec
Copy link
Copy Markdown

No description provided.

@wolfadex
Copy link
Copy Markdown

@Mouhamedtec would you be able to elaborate on your changes here? I'm not as literate in Python and would like to forward this change request to our SDK team with as much context as possible.

@Mouhamedtec
Copy link
Copy Markdown
Author

Mouhamedtec commented May 23, 2022 via email

@wolfadex
Copy link
Copy Markdown

wolfadex commented Jun 6, 2022

@Mouhamedtec do you by chance have a GitHub gist or similar describing your changes? I can't download a PDF at work. Thank you for you time.

@Mouhamedtec
Copy link
Copy Markdown
Author

Mouhamedtec commented Jun 6, 2022 via email

@wolfadex
Copy link
Copy Markdown

wolfadex commented Jun 7, 2022

@Mouhamedtec thanks for the gist! I can't guarantee that these changes will be included but I'll pass the information along to our team that builds the SDK generation tools. We appreciate you taking the time to both make the PR and write out the reasoning.

@zenmasterjobo
Copy link
Copy Markdown

hi @Mouhamedtec - thanks for bringing up this up and taking the time to write a new class! Unfortunately we won't be bringing in these changes at this time. Thank you very much for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants