This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Fixes crash when not specifying a @WithModule annotation with the ScreenScoper#150
Merged
Conversation
When loading a screen without a module annotation, this crash happens:
java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference
at dagger.internal.Modules.loadModules(Modules.java:43)
at dagger.ObjectGraph$DaggerObjectGraph.makeGraph(ObjectGraph.java:174)
at dagger.ObjectGraph$DaggerObjectGraph.plus(ObjectGraph.java:204)
at mortar.dagger1support.ObjectGraphService.create(ObjectGraphService.java:26)
at eu.yesweapp.skeleton.mortarflow.screen.ScreenScoper.getScreenScope(ScreenScoper.java:55)
Contributor
|
Nice, thanks. Can you sign our CLA so I can merge the fix? https://github.com/square/mortar/blob/master/CONTRIBUTING.md |
Contributor
Author
|
Done, thanks Ray! |
rjrjr
added a commit
that referenced
this pull request
May 2, 2015
Fixes crash when not specifying a @WithModule annotation with the ScreenScoper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a screen without a module annotation, this crash happens: