Skip to content

PR: Add QtCharts alias for backward compatibility with 1.x#315

Merged
CAM-Gerlach merged 3 commits intospyder-ide:masterfrom
dalthviz:fixes_issue_304
Jan 20, 2022
Merged

PR: Add QtCharts alias for backward compatibility with 1.x#315
CAM-Gerlach merged 3 commits intospyder-ide:masterfrom
dalthviz:fixes_issue_304

Conversation

@dalthviz
Copy link
Copy Markdown
Member

@dalthviz dalthviz commented Jan 17, 2022 •
edited
Loading

Fixes #304

Note: Needs a rebase after #313 is merged

@dalthviz dalthviz added this to the v2.0.1 milestone Jan 17, 2022
@dalthviz dalthviz self-assigned this Jan 17, 2022
@dalthviz dalthviz changed the title PR: Add QtCharts alias for backward compatibility with 1.x [WIP] PR: Add QtCharts alias for backward compatibility with 1.x Jan 17, 2022
CAM-Gerlach
CAM-Gerlach requested changes Jan 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you're importing QtCharts in init, this makes the separate QtCharts module a hard dependency of QtPy, instead of just users importing qtpy.QtCharts, This also causes our tests to fail on platforms that don't have it by default, on which the test would normally be skipped (aside from the coverage-related failure you fixed in #313 ). Can you do this manipulation inside qtpy.QtCharts instead of in `init to resolve this issue? Thanks!

@CAM-Gerlach
Copy link
Copy Markdown
Member

CAM-Gerlach commented Jan 18, 2022

@dalthviz Just curious—is there a reason for using the the manual [WiP] title "tag" instead of marking as draft?

@dalthviz
Copy link
Copy Markdown
Member Author

dalthviz commented Jan 18, 2022

@dalthviz Just curious—is there a reason for using the the manual [WiP] title "tag" instead of marking as draft?

Pure habit basically

@dalthviz dalthviz changed the title [WIP] PR: Add QtCharts alias for backward compatibility with 1.x PR: Add QtCharts alias for backward compatibility with 1.x Jan 18, 2022
@dalthviz dalthviz requested a review from CAM-Gerlach January 18, 2022 15:10
ccordoba12
ccordoba12 reviewed Jan 18, 2022
View reviewed changes
@dalthviz dalthviz requested a review from ccordoba12 January 19, 2022 15:19
ccordoba12
ccordoba12 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

CAM-Gerlach
CAM-Gerlach approved these changes Jan 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dalthviz !

@CAM-Gerlach CAM-Gerlach merged commit 74dd309 into spyder-ide:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels

type:Enhancement

Projects

None yet

Milestone

v2.0.1

Development

Successfully merging this pull request may close these issues.

Qt6: QtCharts namespace incompatibility

3 participants

@dalthviz @CAM-Gerlach @ccordoba12