PR: Add missing `QtGui` utility function to `QtCore.Qt` for PySide bindings by dalthviz · Pull Request #313 · spyder-ide/qtpy

dalthviz · 2022-01-13T15:45:33Z

Fixes #311

Edit: Also fixes an issue with PyQt6 and sip to use mightBeRichText:

ccordoba12

Thanks @dalthviz for this! I left two small comments, otherwise looks good to me.

qtpy/QtCore.py

CAM-Gerlach

Thanks @dalthviz ! Looks like @ccordoba12 's suggestions were implemented, so this is ready to go with a couple trivial comments

.github/workflows/ci.yml

qtpy/QtCore.py

Improve comment punctuation/caps Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

ccordoba12

Looks good to me now, thanks @dalthviz!

CAM-Gerlach

LGTM now, thanks @dalthviz !

CAM-Gerlach · 2022-01-18T01:40:42Z

Merging so we can fix the tests in the other PRs.

StSav012 · 2023-11-01T08:28:58Z

qtpy/QtCore.py

+    # trying to import `PyQt6.QtGui.Qt`, some functions like
+    # `PyQt6.QtCore.Qt.mightBeRichText` are missing.
+    try:
+        from PyQt6.QtGui import Qt


Just out of curiosity, shouldn't this overwrite the Qt imported from PyQt6.QtCore a bit earlier?

StSav012

I've stumbled upon the issue #311 while looking through the comments in the qtpy.QtCore code. Although it's merged ages ago, I'd like to discuss the fix a little.

What versions of PyQt6, PySide2, and PySide6 require the fix? I can't tell whether the code is long obsolete or still needed. Please clarify this somewhere.

dalthviz · 2023-11-01T22:12:30Z

What versions of PyQt6, PySide2, and PySide6 require the fix? I can't tell whether the code is long obsolete or still needed. Please clarify this somewhere.

Due the dates the issue was raised and fixed I would guess that is needed for Qt 6.1 or 6.2 bindings (although not completely sure 🤔). Also, did a quick check using PySide2 5.15.2.1 and I got this:

So the fix is at least required by PySide 5.15.2.1. Could you give it a try to the Qt 6.2 bindings to check if the fix is still necessary there?

StSav012 · 2023-11-02T15:47:11Z

So, the tests I've conducted gave the following results:

Flavor	`QtCore.qVersion()`	`hasattr(QtCore.Qt, "mightBeRichText")`	`hasattr(QtGui.Qt, "mightBeRichText"))`
`PySide2`	`5.13.2`, `5.15.2`	`False`	`True`
`PySide6`	`6.2.4`, `6.5.3`, `6.6.0`	`False`	`True`
`PyQt5`	`5.13.2`, `5.15.2`	`True`	`'PyQt5.QtGui' has no attribute 'Qt'`
`PyQt6`	`6.2.4`, `6.5.3`, `6.6.0`	`True`	`'PyQt6.QtGui' has no attribute 'Qt'`

So, the fix is required for all current PySide versions, but shouldn't be here for PyQt6.

But that's not all.

Flavor	`set(dir(QtGui.Qt)) - set(dir(QtCore.Qt))`
`PySide2`	`{'convertFromPlainText', 'codecForHtml', 'mightBeRichText'}`
`PySide6`	`{'convertFromPlainText', 'mightBeRichText'}`

Shouldn't convertFromPlainText be defined for PyQt5 and PyQt6 then, too?

def convertFromPlainText(plain: str, mode: Qt.WhiteSpaceMode = Qt.WhiteSpaceMode.WhiteSpacePre) -> str:
    import html

    plain = html.escape(plain)
    if mode == Qt.WhiteSpaceMode.WhiteSpacePre:
        plain = plain.replace(" ", "\xa0").replace("\t", "\xa0" * 4)
    return "<p>" + plain + "</p>"

dalthviz · 2023-11-03T20:54:33Z

Thanks for the new info @StSav012 ! Could you open a new issue with your findings? Seems like we need to work in a couple of things indeed

StSav012 · 2023-11-07T10:43:05Z

I'm unsure whether it's worth it. I've run [a for a in dir(QtCore.Qt) if a[0].islower()] (to filter the constants and classes out) for various flavors.

Flavor	`[a for a in dir(QtCore.Qt) if a[0].islower()]`
`PyQt5-Qt5==5.15.2`	`['black', 'blue', 'color0', 'color1', 'cyan', 'darkBlue', 'darkCyan', 'darkGray', 'darkGreen', 'darkMagenta', 'darkRed', 'darkYellow', 'gray', 'green', 'lightGray', 'magenta', 'red', 'transparent', 'white', 'yellow']`
`PySide2==5.13.2`	`['black', 'blue', 'color0', 'color1', 'cyan', 'darkBlue', 'darkCyan', 'darkGray', 'darkGreen', 'darkMagenta', 'darkRed', 'darkYellow', 'gray', 'green', 'lightGray', 'magenta', 'red', 'transparent', 'white', 'yellow']`
`PyQt6-Qt6==6.6.0`	`['bin', 'bom', 'center', 'dec', 'endl', 'fixed', 'flush', 'forcepoint', 'forcesign', 'hex', 'left', 'lowercasebase', 'lowercasedigits', 'noforcepoint', 'noforcesign', 'noshowbase', 'oct', 'reset', 'right', 'scientific', 'showbase', 'uppercasebase', 'uppercasedigits', 'ws']`
`PySide6-Essentials==6.6.0`	`['beginPropertyUpdateGroup', 'bin', 'bom', 'center', 'dec', 'endPropertyUpdateGroup', 'endl', 'fixed', 'flush', 'forcepoint', 'forcesign', 'hex', 'left', 'lowercasebase', 'lowercasedigits', 'noforcepoint', 'noforcesign', 'noshowbase', 'oct', 'reset', 'right', 'scientific', 'showbase', 'uppercasebase', 'uppercasedigits', 'ws']`

All but the two first ones differ. Does anyone need the functions to spend time porting them?

As for convertFromPlainText, it's nowhere to be found. Weirdly. Not even in PyQt*.QtCore. So, the flavors are compatible in this sense.

dalthviz · 2023-11-10T22:02:29Z

All but the two first ones differ. Does anyone need the functions to spend time porting them?

I guess for the moment no since no issue has been opened regarding that but it's good to know the variations that we could potentially handle

And thanks for opening the issue!

QtCore: Add missing QtGui utility function to QtCore.Qt

b9c123c

dalthviz added the type:Bug label Jan 13, 2022

dalthviz added this to the v2.0.1 milestone Jan 13, 2022

dalthviz requested review from CAM-Gerlach and ccordoba12 January 13, 2022 15:45

dalthviz self-assigned this Jan 13, 2022

dalthviz changed the title ~~PR: Add missing QtGui utility function to QtCore.Qt for PySide bindings~~ PR [WIP]: Add missing QtGui utility function to QtCore.Qt for PySide bindings Jan 13, 2022

dalthviz changed the title ~~PR [WIP]: Add missing QtGui utility function to QtCore.Qt for PySide bindings~~ [WIP] PR: Add missing QtGui utility function to QtCore.Qt for PySide bindings Jan 13, 2022

QtCore: Enable QtGui/Qt namespace test for PyQt

93904bd

dalthviz changed the title ~~[WIP] PR: Add missing QtGui utility function to QtCore.Qt for PySide bindings~~ PR: Add missing QtGui utility function to QtCore.Qt for PySide bindings Jan 13, 2022

dalthviz force-pushed the fixes_issue_311 branch 3 times, most recently from 9542944 to 9de93c6 Compare January 13, 2022 17:11

ccordoba12 reviewed Jan 13, 2022

View reviewed changes

qtpy/QtCore.py Show resolved Hide resolved

qtpy/QtCore.py Show resolved Hide resolved

dalthviz added 2 commits January 13, 2022 12:39

Update testing and prevent errors with PySide2 5.12

1f72321

QtCore: Remove guiQt after utility functions assignment

f94ceca

dalthviz force-pushed the fixes_issue_311 branch from 28723d3 to f94ceca Compare January 13, 2022 17:41

dalthviz requested a review from ccordoba12 January 14, 2022 15:02

dalthviz mentioned this pull request Jan 14, 2022

PR: Add mapping for missing enum values aliases on QtCore.Qt #314

Merged

CAM-Gerlach approved these changes Jan 14, 2022

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

qtpy/QtCore.py Outdated Show resolved Hide resolved

dalthviz and others added 2 commits January 17, 2022 09:33

QtCore: Apply suggestions from code review

b817223

Improve comment punctuation/caps Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

CI: Update timeout to 15 min

03baeee

dalthviz requested a review from CAM-Gerlach January 17, 2022 14:39

ccordoba12 approved these changes Jan 17, 2022

View reviewed changes

This was referenced Jan 17, 2022

PR: Add QtCharts alias for backward compatibility with 1.x #315

Merged

PR: Fix mappings of instance method and slot alias (PyQt6 and PySide6) #308

Merged

CAM-Gerlach approved these changes Jan 18, 2022

View reviewed changes

CAM-Gerlach merged commit 3d17033 into spyder-ide:master Jan 18, 2022

StSav012 reviewed Nov 1, 2023

View reviewed changes

StSav012 mentioned this pull request Nov 7, 2023

Odd code found for PyQt6: always raises an exception #469

Open

Uh oh!

Conversation

dalthviz commented Jan 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ccordoba12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

CAM-Gerlach left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ccordoba12 left a comment

Choose a reason for hiding this comment

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

CAM-Gerlach commented Jan 18, 2022

Uh oh!

StSav012 Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StSav012 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dalthviz commented Nov 1, 2023

Uh oh!

StSav012 commented Nov 2, 2023

Uh oh!

dalthviz commented Nov 3, 2023

Uh oh!

StSav012 commented Nov 7, 2023

Uh oh!

dalthviz commented Nov 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dalthviz commented Jan 13, 2022 •

edited

Loading

CAM-Gerlach left a comment •

edited

Loading

StSav012 Nov 1, 2023 •

edited

Loading

StSav012 left a comment •

edited

Loading