fix: respect @JsonUnwrapped & @Schema on props not fields only#2894
Merged
bnasslahsen merged 1 commit intospringdoc:mainfrom Feb 8, 2025
wingsofovnia:fix/2879
Merged
fix: respect @JsonUnwrapped & @Schema on props not fields only#2894bnasslahsen merged 1 commit intospringdoc:mainfrom wingsofovnia:fix/2879
@JsonUnwrapped & @Schema on props not fields only#2894bnasslahsen merged 1 commit intospringdoc:mainfrom
wingsofovnia:fix/2879
Conversation
mpleine
pushed a commit
to mpleine/springdoc-openapi
that referenced
this pull request
May 17, 2025
fix: respect `@JsonUnwrapped` & `@Schema` on props not fields only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than introspecting only fields for
@JsonUnwrappedand@Schema, this PR switches to analyzing class properties using Jackson's introspection API.This fixes a regression introduced (supposedly) in v2.6.0, affecting codebases where
@JsonUnwrappedis placed on getters instead of fields - a valid location per annotation's target and respected by Jackson. This change eliminates disparities between how Springdoc displays DTOs and how Jackson interprets them.The test and expected JSON are copied from app224, with the only modification being the relocation of
@JsonUnwrappedto the getter.Fixes #2879