fix defaultValue when using @PageableDefault together with one-indexed-parameters#2881
Merged
bnasslahsen merged 2 commits intospringdoc:mainfrom Feb 8, 2025
Merged
Conversation
Collaborator
|
Thank you for your contribution to the project! |
mpleine
pushed a commit
to mpleine/springdoc-openapi
that referenced
this pull request
May 17, 2025
…efault fix defaultValue when using @PageableDefault together with one-indexed-parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
we noticed that the default value for the page was 0 when having a spring-boot application with
spring.data.web.pageable.one-indexed-parameters=trueas well as using a@PageableDefaulton the controller.The
@PageableDefaultannotation has 0 as the default value for the page (see here). This is the desired behavior (as far as I can tell) as spring normalizes the pageable before injecting it into the controller method. This is done in this method.So, e.g., if the newly added test controller was to be called with the following query parameters
the injected pageable in the controller would return 0 for getPageNumber()
Let me know if you prefer to have a separate TestApp for this, happy to adjust this.