Provide possibility to use custom cache to store JWK Set#8332
Closed
20fps wants to merge 1 commit intospring-projects:masterfrom
20fps:master
Closed
Provide possibility to use custom cache to store JWK Set#833220fps wants to merge 1 commit intospring-projects:masterfrom 20fps:master
20fps wants to merge 1 commit intospring-projects:masterfrom
20fps:master
Conversation
jzheaux
requested changes
Apr 6, 2020
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
Outdated
Show resolved
Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
Outdated
Show resolved
Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
Outdated
Show resolved
Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
Outdated
Show resolved
Hide resolved
jzheaux
requested changes
Apr 7, 2020
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
Outdated
Show resolved
Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
Outdated
Show resolved
Hide resolved
jzheaux
requested changes
Apr 8, 2020
Contributor
jzheaux
left a comment
There was a problem hiding this comment.
I've left just one more comment.
In light of that comment, would you also add a test that confirms that a JwtException, not a BadJwtException is thrown when using a faulty RestOperations in conjunction with a Cache?
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
Outdated
Show resolved
Hide resolved
jzheaux
approved these changes
Apr 10, 2020
Contributor
|
In preparation for merging, @20fps, would you please squash your commits and format the remaining one to look something like: |
Author
np, done |
jzheaux
pushed a commit
that referenced
this pull request
Apr 10, 2020
jzheaux
added a commit
that referenced
this pull request
Apr 10, 2020
- Follow convention to prefix member variable references with "this." - Reduce stack trace when IOException is thrown - Name tests to follow conventions Issue gh-8332
jzheaux
added a commit
that referenced
this pull request
Apr 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update according to the changes requested here #7639 by @jzheaux to have a possibility to use spring Cache to store JWK Set.