Allow using username in Active Directory LDAP search filter#3950
Closed
zhoppy1 wants to merge 1 commit intospring-projects:masterfrom
Closed
Allow using username in Active Directory LDAP search filter#3950zhoppy1 wants to merge 1 commit intospring-projects:masterfrom
zhoppy1 wants to merge 1 commit intospring-projects:masterfrom
Conversation
|
@zhoppy1 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Contributor
|
Related to #249 |
Contributor
|
Thanks for submitting this PR @zhoppy1. We are currently re-thinking our approach to an Active Directory The work has already started in #4064 if you would like to track the progress and provide any input/feedback. I'm going to close this PR as we will address your input/feedback in #4064. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When customizing the LDAP search filter used by
ActiveDirectoryLdapAuthenticationProviderI have a need to reference just the username. The default{0}isusername@domain. This small change will allow filters to reference the username with{1}Example:
Trying to set the filter to use sAMAccountName instead of userPrincipalName results in the domain name being included.
Results in
(&(objectClass=user)(sAMAccountName=someUser@bar.com))This code change will let me use
{1}in the filter instead so the search will be:(&(objectClass=user)(sAMAccountName=someUser))I was unable to simply extend
ActiveDirectoryLdapAuthenticationProviderbecause it is marked final.