Skip to content

Add username as an option for SearchFilter#249

Closed
kirktarou wants to merge 1 commit intospring-projects:masterfrom
kirktarou:master
Closed

Add username as an option for SearchFilter#249
kirktarou wants to merge 1 commit intospring-projects:masterfrom
kirktarou:master

Conversation

@kirktarou
Copy link
Copy Markdown

@kirktarou kirktarou commented Dec 23, 2015

Currently, search filter substitutions are limited only to the bindPrincipal (username@domain).
'username' value will be substituted with {1}

@kirktarou
Add username as an option for SearchFilter
a419d8b 
Currently, search filter substitutions are limited only to the bindPrincipal (username@domain).
'username' value will be substituted with {1}
@aabeling
Copy link
Copy Markdown

aabeling commented Jun 1, 2016

This seems to be a solution for #3303

@pivotal-issuemaster
Copy link
Copy Markdown

pivotal-issuemaster commented Jun 9, 2016

@Kirkalicious Please sign the Contributor License Agreement!

@pivotal-issuemaster
Copy link
Copy Markdown

pivotal-issuemaster commented Jun 15, 2016

@Kirkalicious Thank you for signing the Contributor License Agreement!

@pivotal-issuemaster
Copy link
Copy Markdown

pivotal-issuemaster commented Jun 15, 2016

@Kirkalicious Thank you for signing the Contributor License Agreement!

@rwinch rwinch modified the milestone: 4.2.0 M1 Aug 15, 2016
@jgrandja jgrandja self-assigned this Aug 31, 2016
@jgrandja
Copy link
Copy Markdown
Contributor

jgrandja commented Aug 31, 2016

@Kirkalicious Thanks for submitting this PR. The search filter substitution for {1} won't take effect based on your changes as the default searchFilter in ActiveDirectoryLdapAuthenticationProvider is set at

(&(objectClass=user)(userPrincipalName={0}))

We also need tests added for this change. After you update the PR I'll merge this.

Thank you.

@jgrandja jgrandja added the status: waiting-for-feedback We need additional information before we can continue label Aug 31, 2016
@jgrandja
Copy link
Copy Markdown
Contributor

jgrandja commented Aug 31, 2016

Related to #3950

@jgrandja jgrandja mentioned this pull request Aug 31, 2016
Closed
@jgrandja jgrandja mentioned this pull request Sep 19, 2016
Closed
@jgrandja
Copy link
Copy Markdown
Contributor

jgrandja commented Sep 19, 2016

Thanks for submitting this PR @Kirkalicious.

We are currently re-thinking our approach to an Active Directory AuthenticationProvider implementation. Our direction is to deprecate ActiveDirectoryLdapAuthenticationProvider and leverage the existing LdapAuthenticationProvider and provide a custom strategy of LdapAuthenticator for Active Directory.

The work has already started in #4064 if you would like to track the progress and provide any input/feedback.

I'm going to close this PR as we will address your input/feedback in #4064.
Thank you.

@jgrandja jgrandja closed this Sep 19, 2016
@jgrandja jgrandja added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 19, 2016
@jgrandja jgrandja removed this from the 4.2.0 M1 milestone Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jgrandja jgrandja

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kirktarou @aabeling @pivotal-issuemaster @jgrandja @rwinch