Add Jackson Support for Objects stored in HttpSession#3812
Closed
jeetmp3 wants to merge 64 commits intospring-projects:masterfrom
Closed
Add Jackson Support for Objects stored in HttpSession#3812jeetmp3 wants to merge 64 commits intospring-projects:masterfrom
jeetmp3 wants to merge 64 commits intospring-projects:masterfrom
Conversation
…ackson deserialization support
…ed in CasAuthenticationToken jackson deserialization
Contributor
Author
|
Thanks for the feedback! |
Member
|
@rwinch , can this be backported to Spring Security? |
Member
|
@driverpt Spring Security 4.2 will be out very soon, so I don't think we will be back porting it. What version do you want it to be back ported to? |
|
@rwinch , thanks for the quick reply. I'm currently using the one used in Spring Boot (4.1.1). Is 4.2.0 M1 a good drop-in replacement for 4.1.1 in Spring Boot ? |
Member
|
Problem is, Spring Boot uses Jackson 2.8.1 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @rwinch sorry it's got delayed. I've created mix-ins to add Jackson support(#3736).
Please review the code and let me know feedback. I've modified some existing classes
DefaultSavedRequestadded builder class with private constructorWebAuthenticationDetailsadded one private constructor to excludeHttpServletRequestdependency in Jackson deserialization.CasAuthenticationToken,RememberMeAuthenticationToken,AnonymousAuthenticationTokenadded new private constructor to ensurekeyHashcorrectly deserialized and added static methods inAbstractAuthenticationTokenwhich helps in constructing these *AuthenticationToken implementationsPS: I havn't update Apache Licence yet. Need your help in updating the same