Skip to content

Fix javadoc warnings for spring-security-oauth2-client#18483

Merged
rwinch merged 1 commit intospring-projects:mainfrom
dasog94:gh-18460
Jan 13, 2026
Merged

Fix javadoc warnings for spring-security-oauth2-client#18483
rwinch merged 1 commit intospring-projects:mainfrom
dasog94:gh-18460

Conversation

@dasog94
Copy link
Copy Markdown

@dasog94 dasog94 commented Jan 12, 2026

image

Fix one javadoc warning.

I took buildSrc/src/main/groovy/javadoc-warnings-error.gradle from PR #18473. It is identical.
Because it works well, so I decided to add.
Please ignore my javadoc-warnings-error.gradle when merging.

Closes gh-18460

@rwinch
Copy link
Copy Markdown
Member

rwinch commented Jan 12, 2026

@dasog94 Thank you for the PR! Would you be able to rebase off the code that was merged (removing the commit for adding the plugin since it was added in the other PR)? Once you do that, can youmark the PR as ready vs a draft?

@rwinch rwinch self-assigned this Jan 12, 2026
@rwinch rwinch added status: waiting-for-feedback We need additional information before we can continue in: build An issue in the build type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 12, 2026
- Fix a javadoc warning
- Apply javadoc-warnings-error plugin

Closes spring-projectsgh-18460

Signed-off-by: Bae Jihong <dasog@naver.com>
@rwinch rwinch marked this pull request as ready for review January 13, 2026 15:11
@rwinch rwinch removed the status: waiting-for-feedback We need additional information before we can continue label Jan 13, 2026
@rwinch rwinch added this to the 7.1.0-M1 milestone Jan 13, 2026
@rwinch
Copy link
Copy Markdown
Member

rwinch commented Jan 13, 2026

Thanks for the PR! This will be merged once the build passes

@dasog94
Copy link
Copy Markdown
Author

dasog94 commented Jan 13, 2026

@rwinch I really appreciate your kind explanation. Thank you very much!

@rwinch rwinch merged commit 8692185 into spring-projects:main Jan 13, 2026
6 checks passed
@dasog94 dasog94 deleted the gh-18460 branch January 31, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: build An issue in the build type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove javadoc warnings for spring-security-oauth2-client

3 participants