Fix Javadoc warnings in spring-security-web#18473
Merged
rwinch merged 2 commits intospring-projects:mainfrom Jan 12, 2026
Merged
Fix Javadoc warnings in spring-security-web#18473rwinch merged 2 commits intospring-projects:mainfrom
rwinch merged 2 commits intospring-projects:mainfrom
Conversation
dasog94
added a commit
to dasog94/spring-security
that referenced
this pull request
Jan 12, 2026
- Fix a javadoc warning - Apply plugin to configure Javadoc to fail on warnings - Note: Based on pending changes in PR spring-projects#18473 Closes spring-projectsgh-18460 Signed-off-by: Jihong Bae <dasog94@gmail.com>
dasog94
pushed a commit
to dasog94/spring-security
that referenced
this pull request
Jan 12, 2026
- Fix a javadoc warning - Apply plugin to configure Javadoc to fail on warnings - Note: Based on pending changes in PR spring-projects#18473 Closes spring-projectsgh-18460 Signed-off-by: Bae Jihong <dasog@naver.com>
rwinch
requested changes
Jan 12, 2026
Member
rwinch
left a comment
There was a problem hiding this comment.
Thank you for the PR. I've provided feedback inline
92a0fa6 to
6da239e
Compare
Signed-off-by: rigu1 <dlsrbtla@gmail.com>
* Use <code> tags for external references in DelegatingMissingAuthorityAccessDeniedHandler and SwitchUserWebFilter * Fix typo in SessionAuthenticationException * Apply javadoc-warnings-error plugin Closes spring-projectsgh-18468 Signed-off-by: rigu1 <dlsrbtla@gmail.com>
6da239e to
b351b48
Compare
Member
|
Thanks again for the PR @Rigu1! This is now scheduled to be merged into main upon the build completing successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the first PR addressing Javadoc warnings (gh-18443), this contribution fixes warnings in the
spring-security-webmodule and implements the requested shared build plugin.1. Fix Javadoc Warnings in
spring-security-webResolved external reference warnings caused by Javadoc links by replacing
@seeand@linkusages with inline<code>tags inDelegatingMissingAuthorityAccessDeniedHandlerandSwitchUserWebFilter.SessionAuthenticationException(
ServerSessionAuthenticationStrategy→SessionAuthenticationStrategy).2. New Build Plugin:
javadoc-warnings-errorA new convention plugin has been added at
buildSrc/src/main/groovy/javadoc-warnings-error.groovy.The plugin configures all Javadoc tasks to fail the build if any warning occurs (
-Werror), preventing Javadoc warnings from being introduced in the future.Usage in other modules
Other modules can enable this behavior by applying the plugin in their
build.gradle:plugins { id 'javadoc-warnings-error' }Closes gh-18468