Skip to content

Create SHA-1 MessageDigest for every new check request in Compromised Password Checker#18235

Merged
rwinch merged 1 commit intospring-projects:6.5.xfrom
garvit-joshi:main
Jan 26, 2026
Merged

Create SHA-1 MessageDigest for every new check request in Compromised Password Checker#18235
rwinch merged 1 commit intospring-projects:6.5.xfrom
garvit-joshi:main

Conversation

@garvit-joshi
Copy link
Copy Markdown
Contributor

closes #18234 .

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 29, 2025
@garvit-joshi garvit-joshi changed the title gh-18234: Create SHA-1 MessageDigest for every new check request #18234: Create SHA-1 MessageDigest for every new check request Nov 29, 2025
@garvit-joshi garvit-joshi changed the title #18234: Create SHA-1 MessageDigest for every new check request Create SHA-1 MessageDigest for every new check request Compromised Password Checker Nov 29, 2025
@garvit-joshi garvit-joshi changed the title Create SHA-1 MessageDigest for every new check request Compromised Password Checker Create SHA-1 MessageDigest for every new check request in Compromised Password Checker Nov 29, 2025
@rwinch
Copy link
Copy Markdown
Member

rwinch commented Jan 24, 2026

Thank you for the PR @garvit-joshi For bug fixes, the target branch should be the earliest supported branch the bug is on.

Would you mind pushing an update that targets the 6.5.x branch (which is the oldest branch that is supported)? I will then merge the PR forward to have it included in the other supported branches.

@rwinch rwinch self-assigned this Jan 24, 2026
@rwinch rwinch added in: core An issue in spring-security-core type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 24, 2026
…ck request

Signed-off-by: Garvit Joshi <garvitjoshi9@gmail.com>
@garvit-joshi garvit-joshi changed the base branch from main to 6.5.x January 25, 2026 10:50
@garvit-joshi
Copy link
Copy Markdown
Contributor Author

Hi @rwinch,

I've rebased this PR onto the 6.5.x branch and updated the target accordingly.

@rwinch rwinch closed this Jan 26, 2026
@rwinch rwinch reopened this Jan 26, 2026
@rwinch rwinch enabled auto-merge (rebase) January 26, 2026 16:53
@rwinch rwinch merged commit edd82ba into spring-projects:6.5.x Jan 26, 2026
10 checks passed
@rwinch rwinch added this to the 6.5.8 milestone Jan 26, 2026
rwinch added a commit that referenced this pull request Jan 26, 2026
@rwinch
Copy link
Copy Markdown
Member

rwinch commented Jan 26, 2026

Thanks for the PR! This is now merged into 6.5.x, 7.0.x, and main!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core An issue in spring-security-core type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HaveIBeenPwnedRestApiPasswordChecker implementations are not thread-safe

3 participants