Add SecurityContextRepository to Kotlin Reactive DSL#15013
Merged
jzheaux merged 1 commit intospring-projects:mainfrom May 31, 2024
Merged
Add SecurityContextRepository to Kotlin Reactive DSL#15013jzheaux merged 1 commit intospring-projects:mainfrom
SecurityContextRepository to Kotlin Reactive DSL#15013jzheaux merged 1 commit intospring-projects:mainfrom
Conversation
jzheaux
requested changes
May 21, 2024
Contributor
jzheaux
left a comment
There was a problem hiding this comment.
Hi, @earlgrey02, thanks for the PR!
Will you please do the following three items for me:
- Add test(s) to confirm the functionality works
- Change copyright dates so they are updated to the current year
- Update the commit message to be brief and in the imperative, like
Add SecurityContextRepository to Kotlin Reactive DSL
0c0df51 to
4df815e
Compare
Contributor
Author
|
Yes, the work has been done. |
ServerSecurityContextRepository of ServerHttpSecurity
jzheaux
approved these changes
May 31, 2024
jzheaux
added a commit
that referenced
this pull request
May 31, 2024
Contributor
|
Thanks again, @earlgrey02! This is now merged into |
SecurityContextRepository to Kotlin Reactive DSL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no way in
ServerHttpSecurityDslto set theServerSecurityContextRepositoryofServerHttpSecurity. So I added a field variable to setServerSecurityContextRepository.