GH-4444: Consider ackTime for COUNT_TIME commits#4449
Merged
Conversation
Signed-off-by: Nikita Kibitkin <nikita.n.kibitkin@gmail.com>
spring-builds
pushed a commit
that referenced
this pull request
May 28, 2026
spring-builds
pushed a commit
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4444
AckMode.COUNT_TIMEsets bothisCountAckandisTimeAck, butListenerConsumer.processCommits()used anif/else ifchain. As a result,countAcks()always won andtimedAcks()was never evaluated forCOUNT_TIME.This updates the commit processing so count-based and time-based checks are both evaluated for
COUNT_TIME, while keeping the regular fallback commit path limited to modes that are neither count-based nor time-based.A regression test verifies that
COUNT_TIMEcommits whenackTimeelapses even ifackCounthas not been reached.