GH-4439: Pass full record list to batch rollback processor#4443
Merged
Conversation
…ollback Signed-off-by: Nikita Kibitkin <nikita.n.kibitkin@gmail.com>
spring-builds
pushed a commit
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4439.
When a batch listener consumes the full
ConsumerRecords, the container keepsrecordListempty because the listener does not use theList<ConsumerRecord>path.On rollback, that empty list was passed to the
AfterRollbackProcessor, so the default processor had no records to seek. This change treats an emptyrecordListthe same way asnulland materializes it from the originalConsumerRecords.I added a regression test for a transactional batch listener with
wantsPollResult=true.Tests:
./gradlew :spring-kafka:checkstyleMain :spring-kafka:checkstyleTest./gradlew :spring-kafka:test --tests org.springframework.kafka.listener.ConcurrentMessageListenerContainerMockTests