Skip to content

Code sample has wrong reference to configurePathMatching#33277

Closed
sheip9 wants to merge 1 commit intospring-projects:mainfrom
sheip9:patch-1
Closed

Code sample has wrong reference to configurePathMatching#33277
sheip9 wants to merge 1 commit intospring-projects:mainfrom
sheip9:patch-1

Conversation

@sheip9
Copy link
Copy Markdown
Contributor

@sheip9 sheip9 commented Jul 26, 2024

In interface WebFluxConfigurer, the method to path matching is "configurePathMatching", NOT "configurePathMatch". Detail is in https://github.com/spring-projects/spring-framework/blob/main/spring-webflux/src/main/java/org/springframework/web/reactive/config/WebFluxConfigurer.java#L129

In interface WebFluxConfigurer, the method to path matching is "configurePathMatching", NOT "configurePathMatch". Detail is in https://github.com/spring-projects/spring-framework/blob/main/spring-webflux/src/main/java/org/springframework/web/reactive/config/WebFluxConfigurer.java#L129
@pivotal-cla
Copy link
Copy Markdown

@sheip9 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link
Copy Markdown

@sheip9 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 26, 2024
@snicoll snicoll added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 26, 2024
@snicoll snicoll self-assigned this Jul 26, 2024
@snicoll snicoll added this to the 6.1.12 milestone Jul 26, 2024
@snicoll snicoll closed this in 9aac24c Jul 26, 2024
@snicoll snicoll changed the title In WebFlux Config docs, part of Path Matching 's code refer a error method Code sample has wrong reference to configurePathMatching Jul 26, 2024
@snicoll
Copy link
Copy Markdown
Member

snicoll commented Jul 26, 2024

@sheip9 thanks very much for making your first contribution to Spring Framework. To avoid that from happening again, I've moved the code sample to actual code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation A documentation task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants