Fix R2dbcTransactionManager debug log: don't log a Mono#29800
Merged
simonbasle merged 1 commit intospring-projects:mainfrom Jan 16, 2023
Merged
Conversation
|
@j-min5u Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@j-min5u Thank you for signing the Contributor License Agreement! |
simonbasle
approved these changes
Jan 11, 2023
Contributor
simonbasle
left a comment
There was a problem hiding this comment.
thanks for the contribution @j-min5u !
Contributor
|
mmh looks like there's an issue with the backport bot. considering that, and the fact the 6.0.4 and 5.3.25 releases are planned for today, I won't rush things and instead reassign this to 6.0.5 and defer merging. |
Contributor
|
TODO
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
There's an issue when logging the current connection inside R2dbcTransactionManager#doBegin :
the mono object is logged instead of the connection lambda parameter, resulting in wrong log
ex)
2023-01-11 15:09:32.809 DEBUG 45809 --- [actor-tcp-nio-2] o.s.r.c.R2dbcTransactionManager : Acquired Connection [MonoRetry] for R2DBC transaction