Deprecate CookieGenerator#28870
Closed
vpavic wants to merge 1 commit into
Closed
Conversation
This commit deprecates CookieGenerator in favor of a more modern alternative in ResponseCookie.
rstoyanchev
pushed a commit
that referenced
this pull request
Sep 28, 2022
This commit deprecates CookieGenerator in favor of the more modern alternative, ResponseCookie. See gh-28870
rstoyanchev
added a commit
that referenced
this pull request
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit deprecates
CookieGeneratorin favor of a more modern alternative inResponseCookie.Ideally, all Framework generated cookies should be consistent is sense they use the same infrastructure for creating response cookies.
CookieGeneratorhas only two usages that either have PRs to replace them withResponseCookie(CookieLocaleResolver) or are about to be deprecated (CookieThemeResolver).Related:
CookieLocaleResolverto useResponseCookie#28779