Clarify docs on JNDI properties in Servlet environment#28488
Closed
arend-von-reinersdorff wants to merge 1 commit intospring-projects:mainfrom
arend-von-reinersdorff:clarify-docs-on-jndi-in-standardservletenvironment
Closed
Clarify docs on JNDI properties in Servlet environment#28488arend-von-reinersdorff wants to merge 1 commit intospring-projects:mainfrom arend-von-reinersdorff:clarify-docs-on-jndi-in-standardservletenvironment
arend-von-reinersdorff wants to merge 1 commit intospring-projects:mainfrom
arend-von-reinersdorff:clarify-docs-on-jndi-in-standardservletenvironment
Conversation
Contributor
arend-von-reinersdorff
commented
May 19, 2022
- Clarified that JndiPropertySource is always enabled. Previous statement "can optionally enable" might have been before Register JndiPropertySource by default in StandardServletEnvironment [SPR-8545] #13189
- Mentioned global off switch JndiLocatorDelegate.IGNORE_JNDI_PROPERTY_NAME in StandardServletEnvironment
snicoll
pushed a commit
that referenced
this pull request
Jul 29, 2022
snicoll
added a commit
that referenced
this pull request
Jul 29, 2022
Member
|
Thanks again @arend-von-reinersdorff |
Contributor
Author
|
Thanks for merging @snicoll :-) You restored the word "including" in this phrase:
I find "including" a bit misleading: It sounds like more than the 3 mentioned property sources could be added by StandardServletEnvironment. But this is not the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.