Simplify default locale/timezone resolution in cookie/session locale resolvers#27609
Closed
vpavic wants to merge 3 commits into
Closed
Simplify default locale/timezone resolution in cookie/session locale resolvers#27609vpavic wants to merge 3 commits into
vpavic wants to merge 3 commits into
Conversation
AudiBram
approved these changes
Nov 17, 2021
muriloalvesdev
approved these changes
Dec 10, 2021
e520124 to
77ce689
Compare
Contributor
Author
|
Any feedback on this? |
Member
Hi @vpavic, We just have not gotten to it yet. We'll review it and hopefully get it into 6.0 M5. |
This commit updates AcceptHeaderLocaleResolver to extend AbstractLocaleResolver, which allows the removal of defaultLocale managing code in AcceptHeaderLocaleResolver.
This commit updates LocaleContextResolver to implement LocaleResolver using default methods, which simplifies AbstractLocaleContextResolver and aligns it more closely with AbstractLocaleResolver.
…resolvers At present, the customization of the default locale and timezone resolution in CookieLocaleResolver and SessionLocaleResolver requires subclassing them and overriding determineDefaultLocale and/or determineDefaultTimeZone methods. This commit simplifies resolution of the default locale and timezone resolution by introducing dedicated functions for these purposes, thus allowing the customization without needing to resort to subclassing the locale resolvers.
Contributor
Author
|
Thanks @sbrannen. In my notes I had a few other improvement proposals that weren't as straightforward as those included in this PR:
Anyway, let me know what you think of those and I can either add commits to this PR or open separate issues (or PRs) to consider those separately. IMO the whole |
77ce689 to
d6bee29
Compare
Member
I'll assess that after merging the three commits in this PR.
Indeed, 6.0 is a good opportunity for "modernization". |
sbrannen
pushed a commit
to sbrannen/spring-framework
that referenced
this pull request
Jun 3, 2022
This commit updates AcceptHeaderLocaleResolver to extend AbstractLocaleResolver, which allows the removal of defaultLocale managing code in AcceptHeaderLocaleResolver. See spring-projectsgh-27609
sbrannen
pushed a commit
that referenced
this pull request
Jun 3, 2022
This commit updates LocaleContextResolver to implement LocaleResolver using default methods, which simplifies AbstractLocaleContextResolver and aligns it more closely with AbstractLocaleResolver. See gh-27609
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present, the customization of the default locale and timezone resolution in
CookieLocaleResolverandSessionLocaleResolverrequires subclassing them and overridingdetermineDefaultLocaleand/ordetermineDefaultTimeZonemethods.This PR simplifies resolution of the default locale and timezone resolution by introducing dedicated functions for these purposes, thus allowing the customization without needing to resort to subclassing the locale resolvers.
Additionally, there are also 2 small commits that improve some aspects of the
LocaleResolverhierarchy:Update
AcceptHeaderLocaleResolverto extendAbstractLocaleResolver:This commit updates AcceptHeaderLocaleResolver to extend AbstractLocaleResolver, which allows the removal of defaultLocale managing code in AcceptHeaderLocaleResolver.
Update
LocaleContextResolverto implementLocaleResolver:This commit updates
LocaleContextResolverto implementLocaleResolverusing default methods, which simplifiesAbstractLocaleContextResolverand aligns it more closely withAbstractLocaleResolver.