Avoid multiple volatile reads/writes in a row where only one is enough#25899
Merged
jhoeller merged 1 commit intospring-projects:masterfrom Nov 5, 2020
Merged
Avoid multiple volatile reads/writes in a row where only one is enough#25899jhoeller merged 1 commit intospring-projects:masterfrom
jhoeller merged 1 commit intospring-projects:masterfrom
Conversation
wind57
reviewed
Oct 12, 2020
.../java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessor.java
Show resolved
Hide resolved
wind57
reviewed
Oct 12, 2020
...g-aop/src/main/java/org/springframework/aop/aspectj/MethodInvocationProceedingJoinPoint.java
Show resolved
Hide resolved
jhoeller
added a commit
that referenced
this pull request
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MethodInvocationProceedingJoinPointuse the same approach as inInjectionPoint.getAnnotations()to do only one volatile read for all calls after field initialization instead of two.AutowiredAnnotationBeanPostProcessorwe are guareded bysynchronizedAbstractCacheManagernewly createdLinkedHashSetalways has some extra capacity, so calculation of it's size +1 is redundant