Refactor with String#isEmpty()#1335
Closed
stonio wants to merge 1 commit intospring-projects:masterfrom
Closed
Conversation
Member
|
@stonio thanks for the PR, we prefer a single commit rather than small atomic commits. Can you please squash all that and push force your branch? |
Contributor
Author
|
@snicoll All my commits squashed into a single commit. |
lqjack
reviewed
Feb 22, 2017
lqjack
left a comment
There was a problem hiding this comment.
does the String (empty()) better then String (.length())?
snicoll
added a commit
that referenced
this pull request
Feb 22, 2017
* pr/1335: Use String#isEmpty()
Member
|
Thanks, we'll backport it to |
XLWW
pushed a commit
to XLWW/spring-framework
that referenced
this pull request
Apr 29, 2018
Closes spring-projectsgh-1335 (cherry picked from commit 7d062df)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish few classes with
.isEmpty()instead of.length() == 0.