Skip to content

Fix QueryMapper deal map nested last big integer bug#4427

Closed
juzq wants to merge 1 commit intospring-projects:mainfrom
juzq:main
Closed

Fix QueryMapper deal map nested last big integer bug#4427
juzq wants to merge 1 commit intospring-projects:mainfrom
juzq:main

Conversation

@juzq
Copy link
Copy Markdown

@juzq juzq commented Jun 26, 2023

fix #4426

@pivotal-cla
Copy link
Copy Markdown

@juzq Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link
Copy Markdown

@juzq Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 26, 2023
christophstrobl pushed a commit that referenced this pull request Jun 28, 2023
…numeric values.

Prior to this fix a path that contains numeric values used as position parameters would have been stripped in a way that left out the last digit. This could lead to wrong path resolution if the incorrectly constructed property name accidentally matched an existing one.

Closes: #4426
Original Pull Request: #4427
christophstrobl added a commit that referenced this pull request Jun 28, 2023
Update tests to make use of ValueSource.
Replace regex based path inspection with segment by segment analysis.

Original Pull Request: #4427
christophstrobl pushed a commit that referenced this pull request Jun 28, 2023
…numeric values.

Prior to this fix a path that contains numeric values used as position parameters would have been stripped in a way that left out the last digit. This could lead to wrong path resolution if the incorrectly constructed property name accidentally matched an existing one.

Closes: #4426
Original Pull Request: #4427
christophstrobl added a commit that referenced this pull request Jun 28, 2023
Update tests to make use of ValueSource.
Replace regex based path inspection with segment by segment analysis.

Original Pull Request: #4427
christophstrobl pushed a commit that referenced this pull request Jun 28, 2023
…numeric values.

Prior to this fix a path that contains numeric values used as position parameters would have been stripped in a way that left out the last digit. This could lead to wrong path resolution if the incorrectly constructed property name accidentally matched an existing one.

Closes: #4426
Original Pull Request: #4427
christophstrobl added a commit that referenced this pull request Jun 28, 2023
Update tests to make use of ValueSource.
Replace regex based path inspection with segment by segment analysis.

Original Pull Request: #4427
christophstrobl pushed a commit that referenced this pull request Jun 28, 2023
…numeric values.

Prior to this fix a path that contains numeric values used as position parameters would have been stripped in a way that left out the last digit. This could lead to wrong path resolution if the incorrectly constructed property name accidentally matched an existing one.

Closes: #4426
Original Pull Request: #4427
christophstrobl added a commit that referenced this pull request Jun 28, 2023
Update tests to make use of ValueSource.
Replace regex based path inspection with segment by segment analysis.

Original Pull Request: #4427
@christophstrobl
Copy link
Copy Markdown
Member

Thanks for your contribution. Merged to main development line and active maintenance branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue we've not yet triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update path not correctly mapped when last segment is multi digit number

4 participants