Refactor JPQL predicate composition by flattening AND/OR#4195
Closed
l2yujw wants to merge 2 commits into
Closed
Conversation
Signed-off-by: l2yuPa <jeungwon28@gmail.com>
Signed-off-by: l2yuPa <jeungwon28@gmail.com>
mp911de
added a commit
that referenced
this pull request
Feb 20, 2026
Introduce factory methods to flatten predicates. Also, avoid list copies. See #4195
mp911de
pushed a commit
that referenced
this pull request
Feb 20, 2026
Signed-off-by: l2yuPa <jeungwon28@gmail.com> Closes #4195
mp911de
added a commit
that referenced
this pull request
Feb 20, 2026
Introduce factory methods to flatten predicates. Also, avoid list copies. See #4195
Member
|
Thank you for your contribution. That's merged, polished, and backported now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Chained predicate composition currently builds nested AND/OR predicate trees internally.
Even if the rendered output is the same, deep nesting makes the structure harder to reason about and maintain.
Changes
Predicate#and/Predicate#orcomposition.AndPredicate/OrPredicaterecords to holdList<Predicate>parts and normalize nested predicates via compact constructors.nest()behavior unchanged.Tests
Notes
There is an existing comment in
Predicate#andsuggesting the current structuring is not ideal.This change addresses that concern while preserving the rendered output (covered by tests).
Checklist