Skip to content

DATAJPA-1061 - Fix Sorting doesn't work for field alias.#276

Closed
GregoireDruant wants to merge 1 commit into
spring-projects:masterfrom
GregoireDruant:master
Closed

DATAJPA-1061 - Fix Sorting doesn't work for field alias.#276
GregoireDruant wants to merge 1 commit into
spring-projects:masterfrom
GregoireDruant:master

Conversation

@GregoireDruant

Copy link
Copy Markdown
Contributor

Extract field aliases in QueryUtils and add them in the set of possible sort criterias, to enable the possibility to sort query results based on fields' aliases.

  • [*] You have read the Spring Data contribution guidelines.
  • [*] There is a ticket in the bug tracker for the project in our JIRA.
  • [*] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [*] You submit test cases (unit or integration tests) that back your changes.
  • [*] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Extract field aliases in QueryUtils and add them in the set of possible sort criterias
@pivotal-issuemaster

Copy link
Copy Markdown

@GregoireDruant Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

Copy link
Copy Markdown

@GregoireDruant Thank you for signing the Contributor License Agreement!

@rafaesc

rafaesc commented Nov 16, 2018

Copy link
Copy Markdown

@dsyer is it possible review this PR?

I have this problem.

@rogiller

Copy link
Copy Markdown

What is the status of this PR? When can it be merged?

schauder pushed a commit that referenced this pull request Jun 24, 2019
Extract field aliases in QueryUtils and add them in the set of possible sort criteria.

Original pull request: #276.
schauder added a commit that referenced this pull request Jun 24, 2019
Tweaked the formatting and the naming of variables.

Original pull request: #276.
schauder pushed a commit that referenced this pull request Jun 24, 2019
Extract field aliases in QueryUtils and add them in the set of possible sort criteria.

Original pull request: #276.
schauder added a commit that referenced this pull request Jun 24, 2019
Tweaked the formatting and the naming of variables.

Original pull request: #276.
schauder pushed a commit that referenced this pull request Jun 24, 2019
Extract field aliases in QueryUtils and add them in the set of possible sort criteria.

Original pull request: #276.
schauder added a commit that referenced this pull request Jun 24, 2019
Tweaked the formatting and the naming of variables.

Original pull request: #276.
@schauder

Copy link
Copy Markdown
Contributor

This is polished, rebased onto master and backported.

Thanks for the patience.

@schauder schauder closed this Jun 24, 2019
stsypanov pushed a commit to stsypanov/spring-data-jpa that referenced this pull request Dec 13, 2019
Extract field aliases in QueryUtils and add them in the set of possible sort criteria.

Original pull request: spring-projects#276.
stsypanov pushed a commit to stsypanov/spring-data-jpa that referenced this pull request Dec 13, 2019
Tweaked the formatting and the naming of variables.

Original pull request: spring-projects#276.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants