Skip to content

Handle multiline subquery removal#2582

Closed
c-fraser wants to merge 1 commit into
spring-projects:2.7.xfrom
paywithextend:issue/gh-2581
Closed

Handle multiline subquery removal#2582
c-fraser wants to merge 1 commit into
spring-projects:2.7.xfrom
paywithextend:issue/gh-2581

Conversation

@c-fraser

@c-fraser c-fraser commented Jun 28, 2022

Copy link
Copy Markdown
Contributor
  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@c-fraser c-fraser changed the title Handle multiline subquery removal. Handle multiline subquery removal Jun 28, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 28, 2022
@c-fraser c-fraser mentioned this pull request Jun 29, 2022
Closed
@freafrea

freafrea commented Jul 13, 2022

Copy link
Copy Markdown

Hi, this looks like almost the same change as the one I've added previously :)
#2557
Do you know of any way of speeding up the acceptance? Already we have both reimplemented the same behaviour.

@edoswaldgo

edoswaldgo commented Jul 19, 2022

Copy link
Copy Markdown

Thank you @c-fraser, @freafrea ! 👍 Hope the fix can be applied soon. We're encountering the issue because we format our queries with new lines.

@freafrea freafrea mentioned this pull request Sep 2, 2022
Closed
@darinmanica darinmanica mentioned this pull request Sep 13, 2022
Closed
@gregturn gregturn closed this in 91cd84e Sep 28, 2022
gregturn added a commit that referenced this pull request Sep 28, 2022
@gregturn
Polishing.
f773701 
Also added more test cases from related pull requests.

Closes #2582.
Related: #2563, #2557, #2603
@gregturn gregturn self-assigned this Sep 28, 2022
@gregturn gregturn added type: bug A general bug in: query-parser Everything related to parsing JPQL or SQL and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 28, 2022
@gregturn gregturn added this to the 3.0 RC1 (2022.0.0) milestone Sep 28, 2022
@c-fraser c-fraser deleted the issue/gh-2581 branch September 29, 2022 12:03
gregturn pushed a commit that referenced this pull request Sep 29, 2022
@c-fraser @gregturn
Handle multiline subquery removal.
0dec0b0 
Closes #2582.
Related: #2563, #2557, #2603
gregturn added a commit that referenced this pull request Sep 29, 2022
@gregturn
Polishing.
7a6f534 
Also added more test cases from related pull requests.

Closes #2582.
Related: #2563, #2557, #2603
gregturn pushed a commit that referenced this pull request Sep 29, 2022
@c-fraser @gregturn
Handle multiline subquery removal.
1ae67c8 
Closes #2582.
Related: #2563, #2557, #2603
gregturn added a commit that referenced this pull request Sep 29, 2022
@gregturn
Polishing.
c116755 
Also added more test cases from related pull requests.

Closes #2582.
Related: #2563, #2557, #2603
@gregturn

gregturn commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

Backported to 2.7.x. and 2.6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gregturn gregturn

Labels

in: query-parser Everything related to parsing JPQL or SQL type: bug A general bug

Projects

None yet

Milestone

3.0 RC1 (2022.0.0)

Development

Successfully merging this pull request may close these issues.

5 participants

@c-fraser @freafrea @edoswaldgo @gregturn @spring-projects-issues