Update TestRestTemplate's default cookie handling to match RestTemplate's#49261
Merged
wilkinsona merged 2 commits intospring-projects:mainfrom Mar 12, 2026
Conversation
dff9449 to
7e42613
Compare
wilkinsona
reviewed
Feb 25, 2026
Member
wilkinsona
left a comment
There was a problem hiding this comment.
Thanks for the PR, @apoorvdarshan. In addition to the two comments I've made, I think some changes to the various other …HttpClientBuilder classes are missing. The required changes will be similar to the changes that you've made for HttpComponentsHttpClientBuilder to honour the cookies configuration.
...t-resttestclient/src/main/java/org/springframework/boot/resttestclient/TestRestTemplate.java
Outdated
Show resolved
Hide resolved
...-boot-http-client/src/main/java/org/springframework/boot/http/client/HttpClientSettings.java
Outdated
Show resolved
Hide resolved
7e42613 to
1a8c7ba
Compare
apoorvdarshan
commented
Feb 25, 2026
Contributor
Author
apoorvdarshan
left a comment
There was a problem hiding this comment.
Thanks for the review feedback @wilkinsona! Both items addressed:
- Updated the
ENABLE_COOKIESdeprecation to "for removal in 4.3.0" - Added an explicit deprecated four-argument
HttpClientSettingsconstructor that delegates to the new five-argument canonical constructor to preserve backward compatibility
Member
|
Thanks. Did you see this additional comment?
|
1a8c7ba to
56c5733
Compare
Contributor
Author
|
Thanks for pointing that out! I've added cookie handling to the other builders:
Reactor Netty's |
…te's See spring-projectsgh-49261 Signed-off-by: Apoorv Darshan <ad13dtu@gmail.com>
56c5733 to
e898779
Compare
wilkinsona
added a commit
to apoorvdarshan/spring-boot
that referenced
this pull request
Mar 12, 2026
…stTemplate's" See spring-projectsgh-49261 Signed-off-by: Andy Wilkinson <andy.wilkinson@broadcom.com>
e898779 to
5721f57
Compare
Member
|
Thank you, @apoorvdarshan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StandardCookieSpec.IGNORE), differing from RestTemplate which uses the HTTP client library's defaultwithCookies(HttpCookies)method for explicit cookie control, following the same pattern aswithRedirects(HttpRedirects)from Align TestRestTemplate default redirect settings to be the same as RestTemplate #43431HttpCookiesenum,HttpComponentsCookieSpecadapter, andcookies()onRestTemplateBuilderHttpClientOption.ENABLE_COOKIESFixes gh-48607
Test plan
TestRestTemplateTests— verifies default cookie spec is now null (library default),withCookies(ENABLE)returns"strict",withCookies(DISABLE)returns"ignoreCookies"HttpClientSettingsTests— verifieswithCookies()and updatedorElse()with cookies fieldHttpClientAutoConfigurationTests— verifies settings construction with new record shape