Skip to content

Add SSL support to auto-configuration for RabbitMQ Streams#48960

Merged
wilkinsona merged 2 commits intospring-projects:mainfrom
jayychoi:add-ssl-for-rabbit-streams
Mar 17, 2026
Merged

Add SSL support to auto-configuration for RabbitMQ Streams#48960
wilkinsona merged 2 commits intospring-projects:mainfrom
jayychoi:add-ssl-for-rabbit-streams

Conversation

@jayychoi
Copy link
Copy Markdown
Contributor

This PR adds SSL support to RabbitMQ Streams auto-configuration, addressing the issue where spring.rabbitmq.ssl.enabled=true only applied to AMQP connections but not to Stream connections. (#43932)

As suggested by wilkinsona, added SSL bundle support alongside SSL configuration for RabbitMQ Streams. For backward compatibility, I added new spring.rabbitmq.stream.ssl properties instead of reusing spring.rabbitmq.ssl. The implementation follows existing patterns in the codebase.

Changes

  • Add spring.rabbitmq.stream.ssl.enabled property.
  • Add spring.rabbitmq.stream.ssl.bundle property.

Related Issue

Closes gh-43932

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 24, 2026
Copy link
Copy Markdown
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @jayychoi. We now have connection details support for Rabbit Streams with the introduction of RabbitStreamConnectionDetails. Could you please update your PR to take that into account?

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Feb 11, 2026
@jayychoi
Copy link
Copy Markdown
Contributor Author

Absolutely. I'll update the PR accordingly.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 11, 2026
@jayychoi jayychoi force-pushed the add-ssl-for-rabbit-streams branch 2 times, most recently from e142bb7 to ba2c4d2 Compare February 12, 2026 05:02
@jayychoi jayychoi requested a review from wilkinsona February 12, 2026 05:17
@wilkinsona wilkinsona self-assigned this Feb 12, 2026
See spring-projectsgh-48960

Signed-off-by: Jay Choi <jayyoungchoi22@gmail.com>
@wilkinsona wilkinsona force-pushed the add-ssl-for-rabbit-streams branch from ba2c4d2 to 0a7f023 Compare March 17, 2026 11:28
wilkinsona added a commit to jayychoi/spring-boot that referenced this pull request Mar 17, 2026
See spring-projectsgh-48960

Signed-off-by: Andy Wilkinson <andy.wilkinson@broadcom.com>
@wilkinsona wilkinsona force-pushed the add-ssl-for-rabbit-streams branch from 0a7f023 to afe6456 Compare March 17, 2026 11:28
wilkinsona added a commit to jayychoi/spring-boot that referenced this pull request Mar 17, 2026
wilkinsona added a commit to jayychoi/spring-boot that referenced this pull request Mar 17, 2026
See spring-projectsgh-48960

Signed-off-by: Andy Wilkinson <andy.wilkinson@broadcom.com>
@wilkinsona wilkinsona force-pushed the add-ssl-for-rabbit-streams branch from afe6456 to 6906d5f Compare March 17, 2026 11:30
wilkinsona added a commit to jayychoi/spring-boot that referenced this pull request Mar 17, 2026
See spring-projectsgh-48960

Signed-off-by: Andy Wilkinson <andy.wilkinson@broadcom.com>
@wilkinsona wilkinsona force-pushed the add-ssl-for-rabbit-streams branch from 6906d5f to 5bb7ae6 Compare March 17, 2026 11:31
@wilkinsona wilkinsona changed the title Add SSL support to auto-configuration for Rabbit Streams Add SSL support to auto-configuration for RabbitMQ Streams Mar 17, 2026
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Mar 17, 2026
@wilkinsona wilkinsona added this to the 4.1.x milestone Mar 17, 2026
See spring-projectsgh-48960

Signed-off-by: Andy Wilkinson <andy.wilkinson@broadcom.com>
@wilkinsona wilkinsona force-pushed the add-ssl-for-rabbit-streams branch from 5bb7ae6 to 391c898 Compare March 17, 2026 12:03
@wilkinsona wilkinsona modified the milestones: 4.1.x, 4.1.0-M3 Mar 17, 2026
@wilkinsona wilkinsona merged commit e71c751 into spring-projects:main Mar 17, 2026
3 checks passed
@wilkinsona
Copy link
Copy Markdown
Member

Thanks very much, @jayychoi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SSL support to auto-configuration for Rabbit Streams

3 participants