Micrometer "enable" annotations property does not cover observed aspect#45601
Closed
nosan wants to merge 1 commit intospring-projects:3.3.xfrom
Closed
Micrometer "enable" annotations property does not cover observed aspect#45601nosan wants to merge 1 commit intospring-projects:3.3.xfrom
nosan wants to merge 1 commit intospring-projects:3.3.xfrom
Conversation
…dAspectConfiguration Introduced conditions to control `ObservedAspect` bean creation based on `management.observations.annotations.enabled` and `micrometer.observations.annotations.enabled` properties Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
Contributor
Author
|
I've created this PR based on |
snicoll
pushed a commit
that referenced
this pull request
May 20, 2025
This commit adds the same conditions that control some observation aspects to control the creation of an `ObservedAspect` bean. It now is guarded by `management.observations.annotations.enabled` and `micrometer.observations.annotations.enabled`. See gh-45601 Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
snicoll
added a commit
that referenced
this pull request
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #45599
When merging this into main,
ObservationAnnotationsEnabledConditionshould be removed and replaced with@ConditionalOnBooleanProperty("management.observations.annotations.enabled"), and the testallowsObservedAspectToBeEnabledWithDeprecatedPropertyshould also be removed.Target branch is 3.3.x