Warn that some Quartz database schema scripts must be modified before use#43955
Closed
timotheeandres wants to merge 1 commit intospring-projects:mainfrom
Closed
Warn that some Quartz database schema scripts must be modified before use#43955timotheeandres wants to merge 1 commit intospring-projects:mainfrom
timotheeandres wants to merge 1 commit intospring-projects:mainfrom
Conversation
…e-schema` https://github.com/quartznet/quartznet/blob/b9574e915496487e9f031174a61efc2ba572433d/database/tables/tables_sqlServer.sql shows that the SQL Server script requires replacing `enter_db_name_here` manually, so we need to make a copy of the script in our project for it to work. If this modification is not satisfactory, feel free to edit it; my goal is simply to inform the next person using SQL Server that there is no easy way of using this property. Signed-off-by: Timothée Andres <andres.timothee@gmail.com>
initialize-schema
wilkinsona
pushed a commit
that referenced
this pull request
Jan 24, 2025
See gh-43955 Signed-off-by: Timothée Andres <andres.timothee@gmail.com>
wilkinsona
added a commit
that referenced
this pull request
Jan 24, 2025
Member
|
Thanks for bringing this to our attention and for the PR, @timotheeandres. It looks like there's a similar problem with Sybase. I've reworked the warning to take this into account as part of merging this. Thanks again for the PR and congratulations on making your first contribution to Spring Boot. |
arefbehboudi
pushed a commit
to arefbehboudi/spring-boot
that referenced
this pull request
Jan 29, 2025
See spring-projectsgh-43955 Signed-off-by: Timothée Andres <andres.timothee@gmail.com> Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
arefbehboudi
pushed a commit
to arefbehboudi/spring-boot
that referenced
this pull request
Jan 29, 2025
See spring-projectsgh-43955 Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/quartznet/quartznet/blob/b9574e915496487e9f031174a61efc2ba572433d/database/tables/tables_sqlServer.sql shows that the SQL Server script requires replacing
enter_db_name_heremanually, so we need to make a copy of the script in our project for it to work.If this modification is not satisfactory, feel free to edit it; my goal is simply to inform the next person using SQL Server that there is no easy way of using this property.