Fix Javadoc link for Hikari#43305
Closed
ngocnhan-tran1996 wants to merge 1 commit intospring-projects:mainfrom
Closed
Fix Javadoc link for Hikari#43305ngocnhan-tran1996 wants to merge 1 commit intospring-projects:mainfrom
ngocnhan-tran1996 wants to merge 1 commit intospring-projects:mainfrom
Conversation
wilkinsona
reviewed
Nov 27, 2024
|
|
||
| private void addUrlJava(Map<String, String> attributes) { | ||
| attributes.put("url-javase-javadoc", "https://docs.oracle.com/en/java/javase/17/docs/api/"); | ||
| attributes.put("url-javase-javadoc", "https://docs.oracle.com/en/java/javase/17/docs/api"); |
Member
There was a problem hiding this comment.
This doesn't seem to be related to linking to Hikari's javadoc so it should be handled separately. Please revert.
ec63fc7 to
b8ccf97
Compare
snicoll
pushed a commit
that referenced
this pull request
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I click HikariDataSource, a
Hikarijavadoc page should be opened in a new tab insteadmodule-summaryReference:
https://docs.spring.io/spring-boot/3.4-SNAPSHOT/how-to/data-access.html#howto.data-access.configure-custom-datasource