Launcher's ClassLoader is no longer parallel capable#41665
Closed
Rajin9601 wants to merge 1 commit intospring-projects:mainfrom
Closed
Launcher's ClassLoader is no longer parallel capable#41665Rajin9601 wants to merge 1 commit intospring-projects:mainfrom
Rajin9601 wants to merge 1 commit intospring-projects:mainfrom
Conversation
|
@Rajin9601 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Rajin9601 Thank you for signing the Contributor License Agreement! |
Member
|
Thanks very much, @Rajin9601. This looks like a regression in 3.2 to me where |
wilkinsona
pushed a commit
that referenced
this pull request
Aug 15, 2024
Member
|
Thanks very much, @Rajin9601 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging deadlock in our application, I found that spring-boot's LaunchedClassLoader is not registered as parallel capable class loader.
Even though LaunchedClassLoader register itself as parallel capable, ClassLoader only accepts registerAsParallelCapable if the super class is also parallel capable.
https://github.com/openjdk/jdk/blob/f174bbd3baf351ae9248b70454b3bc5a89acd7c6/src/java.base/share/classes/java/lang/ClassLoader.java#L270-L284
Looking at this issue (#7333), it seems LaunchedClassLoader is parallel capable. So this PR registers LaunchedClassLoader's parent class, JarUrlClassLoader as parallel capable.