Image building runs for a long time when a long image name is used and the tag contains an illegal character#39617
Closed
wanger26 wants to merge 1 commit intospring-projects:mainfrom
Closed
Image building runs for a long time when a long image name is used and the tag contains an illegal character#39617wanger26 wants to merge 1 commit intospring-projects:mainfrom
wanger26 wants to merge 1 commit intospring-projects:mainfrom
Conversation
0a2b463 to
4c953b9
Compare
Contributor
|
Thanks @wanger26. This change looked good to me, but a test somewhere else in the project failed. A test added to A single character (lower-case alpha or numeric) after a Note that the Do you want to try to address this issue? |
84f3a60 to
195fac7
Compare
Contributor
Author
|
@scottfrederick I can address the build issue as well as make the recommended adjustments. I am going to steal that test case too if you don't mind to make sure we get it right 💯 |
195fac7 to
49c8297
Compare
- Simplify regular expression checking for validity of Image Reference to fix Catastrophic Backtracking for long custom images with illegal characters in tag spring-projects#39246
49c8297 to
103a232
Compare
scottfrederick
pushed a commit
that referenced
this pull request
Feb 20, 2024
Update the regular expression used to parse Docker images references to prevent catastrophic backtracking when images names are long and the tag contains an illegal character. See gh-39617
scottfrederick
added a commit
that referenced
this pull request
Feb 20, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Issue