Skip to content

Add note regarding mixing of bundle-based and direct SSL configuration#39616

Closed
wanger26 wants to merge 2 commits intospring-projects:mainfrom
wanger26:Issue-39310
Closed

Add note regarding mixing of bundle-based and direct SSL configuration#39616
wanger26 wants to merge 2 commits intospring-projects:mainfrom
wanger26:Issue-39310

Conversation

@wanger26
Copy link
Contributor

@wanger26 wanger26 commented Feb 18, 2024

Change Summary

  • Clarify that mixing of bundle-based configuration and directly configuring the server's SSL settings is not supported and that you should only use one or the other.

Issue

@wanger26
DOCS - Add note regarding mixing of bundle-based and direct ssl configs
264ed0c 
- Clarify that mixing of bundle-based configuration and directly configuring the server's SSL settings is not supported and that you should only use one or the other.

spring-projects#39310

Signed-off-by: Jakob Wanger <jakobwanger@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 18, 2024
@scottfrederick
Copy link
Contributor

scottfrederick commented Feb 19, 2024

@wanger26 Thanks for the PR.

The issue #39310 is specific to the configuration of SSL for embedded web servers. As such, a better place for the note would be in the section that is specific to that configuration here.

Also, the use of the ssl.bundle property can't be combined with either the discrete JKS or PEM property options under server.ssl.

Would you mind making those changes in a new commit and updating the PR?

@scottfrederick scottfrederick added the status: waiting-for-feedback We need additional information before we can continue label Feb 19, 2024
@wanger26
DOCS - Adjust location and wording for mixing of ssl configs
adab052 
Signed-off-by: Jakob Wanger <jakobwanger@gmail.com>
@wanger26
Copy link
Contributor Author

wanger26 commented Feb 19, 2024

@wanger26 Thanks for the PR.

The issue #39310 is specific to the configuration of SSL for embedded web servers. As such, a better place for the note would be in the section that is specific to that configuration here.

Also, the use of the ssl.bundle property can't be combined with either the discrete JKS or PEM property options under server.ssl.

Would you mind making those changes in a new commit and updating the PR?

I updated the wording and the location. Good catch @scottfrederick! 💯. Please let me know what you think of the new location and wording.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 19, 2024
@scottfrederick scottfrederick added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Feb 20, 2024
@scottfrederick scottfrederick added this to the 3.1.9 milestone Feb 20, 2024
@scottfrederick scottfrederick changed the title DOCS - Add note regarding mixing of bundle-based and direct ssl configs Add note regarding mixing of bundle-based and direct SSL configuration Feb 20, 2024
This was referenced Feb 20, 2024
Closed
Closed
scottfrederick pushed a commit that referenced this pull request Feb 20, 2024
@wanger26 @scottfrederick
Add note regarding mixing of bundle-based and direct SSL configuration
4c069f0 
Signed-off-by: Jakob Wanger <jakobwanger@gmail.com>

See gh-39616
scottfrederick added a commit that referenced this pull request Feb 20, 2024
@scottfrederick
Polish "Add note regarding mixing of bundle-based and direct SSL conf…
eb4d6e7 
…iguration"

See gh-39616
@scottfrederick
Copy link
Contributor

scottfrederick commented Feb 20, 2024

Thanks again @wanger26. I moved the note down just a bit further in the file and removed a few words in eb4d6e7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: documentation A documentation update

Projects

None yet

Milestone

3.1.9

Development

Successfully merging this pull request may close these issues.

3 participants

@wanger26 @scottfrederick @spring-projects-issues