SpringProfile arbiter fails without a Spring's environment#39403
Closed
timgrohmann wants to merge 1 commit intospring-projects:mainfrom
Closed
SpringProfile arbiter fails without a Spring's environment#39403timgrohmann wants to merge 1 commit intospring-projects:mainfrom
timgrohmann wants to merge 1 commit intospring-projects:mainfrom
Conversation
|
@timgrohmann Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@timgrohmann Thank you for signing the Contributor License Agreement! |
Contributor
|
@philwebb As Log4j seems to have it's own SpringProfileArbiter which looks like ours, could we use that? |
Member
|
I don't think we can do that as it would introduce an (even stronger) cyclic dependency between the two projects. |
Contributor
Author
|
Can we still integrate the upstream change into this project to fix the problem for Spring Boot users? |
Contributor
|
Yeah, I'll flag it to talk about it in our team meeting. |
mhalbritter
pushed a commit
that referenced
this pull request
Feb 28, 2024
Contributor
|
Thank you very much and congratulations on your first contribution 🎉! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A issue has been raised and fixed in
apache/logging-log4j2: apache/logging-log4j2#1783A detailed explanation of the proposed change may be found in this issue.
Basically, the null check for the environment is not necessary in the builder as the
isCondition()method already correctly checks for a null environment.