Skip to content

Update Dynatrace documentation links#38706

Closed
pirgeo wants to merge 1 commit into
spring-projects:3.1.xfrom
dynatrace-oss-contrib:update-dynatrace-doc-links
Closed

Update Dynatrace documentation links#38706
pirgeo wants to merge 1 commit into
spring-projects:3.1.xfrom
dynatrace-oss-contrib:update-dynatrace-doc-links

Conversation

@pirgeo

@pirgeo pirgeo commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

At Dynatrace, the documentation URLs now have an overhauled format, including new shortlinks. This PR swaps out the "old" links with the new style of shortlink in the documentation.

I based this PR on 2.7.x, since the docs for that are still up (and 2.7 is still in commercial support IIUC). Will these changes be merged forward? Or should I just create a PR based on 3.1.x instead, since that is the officially supported version?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 7, 2023

@arminru arminru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread spring-boot-project/spring-boot-docs/src/docs/asciidoc/attributes.adoc Outdated
@wilkinsona

Copy link
Copy Markdown
Member

Please update the base branch to 3.1.x. The 2.7.x (and 3.0.x) branches are now read-only as OSS support has ended.

@pirgeo pirgeo force-pushed the update-dynatrace-doc-links branch from 2978a7e to e2ebe93 Compare December 7, 2023 16:06
@pirgeo pirgeo changed the base branch from 2.7.x to 3.1.x December 7, 2023 16:07
@pirgeo

pirgeo commented Dec 7, 2023

Copy link
Copy Markdown
Contributor Author

Rebased onto 3.1.x, changed the base branch and addressed the review comments.

@pirgeo pirgeo requested a review from wilkinsona December 7, 2023 16:09
@philwebb philwebb added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 7, 2023
@philwebb philwebb added this to the 3.1.x milestone Dec 7, 2023
@mhalbritter

Copy link
Copy Markdown
Contributor

Thank you!

@mhalbritter mhalbritter modified the milestones: 3.1.x, 3.1.7 Dec 11, 2023
@pirgeo pirgeo deleted the update-dynatrace-doc-links branch December 11, 2023 07:33
@pirgeo pirgeo restored the update-dynatrace-doc-links branch December 11, 2023 07:33
@pirgeo pirgeo deleted the update-dynatrace-doc-links branch December 11, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants