Use more idiomatic Kotlin in example for "Map Health Indicators to Micrometer Metrics"#37491
Closed
rlaope wants to merge 1 commit intospring-projects:mainfrom
Closed
Use more idiomatic Kotlin in example for "Map Health Indicators to Micrometer Metrics"#37491rlaope wants to merge 1 commit intospring-projects:mainfrom
rlaope wants to merge 1 commit intospring-projects:mainfrom
Conversation
MyHealthMetricsExportConfiguration's private fun getStatusCode()
Member
|
This is great. Thanks very much, @esperar. |
Contributor
|
Thank you very much and congratulations on your first contribution 🎉! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I am a 16-year-old developer who lives in Korea., I was looking at the spring docs part developed by Kotlin and saw MyHealth
Metrics ExportConfiguration's private fun getStatusCode(). It was using the if statement to return it, so I suggest using awhenstatement while using Kotlin!Before
After
or
If you want to apply the second option, please leave a comment I'll change it.
Thank you :)