Closed
Conversation
|
@hakan-krgn Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@hakan-krgn Thank you for signing the Contributor License Agreement! |
wilkinsona
requested changes
Aug 29, 2023
Member
wilkinsona
left a comment
There was a problem hiding this comment.
Thanks for the PR, @hakan-krgn. I've left a few comments for your consideration.
...ringframework/boot/test/autoconfigure/OverrideAutoConfigurationContextCustomizerFactory.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/boot/test/autoconfigure/json/JsonTestersAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/boot/test/autoconfigure/json/JsonTestersAutoConfiguration.java
Outdated
Show resolved
Hide resolved
Closed
wilkinsona
approved these changes
Aug 30, 2023
Member
|
Thanks very much, @hakan-krgn. |
wilkinsona
pushed a commit
that referenced
this pull request
Aug 30, 2023
wilkinsona
added a commit
that referenced
this pull request
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this PR fixes some grammar issues in Javadocs and improves code bases. Additionally, resolves a potential null pointer issue in JsonTestersAutoConfiguration.