Documentation of spring.redis.url incorrectly states that it does not override spring.redis.user#36477
Closed
izeye wants to merge 1 commit intospring-projects:mainfrom
Closed
Documentation of spring.redis.url incorrectly states that it does not override spring.redis.user#36477izeye wants to merge 1 commit intospring-projects:mainfrom
izeye wants to merge 1 commit intospring-projects:mainfrom
Conversation
Member
|
When merging forwards, the property becomes |
wilkinsona
pushed a commit
that referenced
this pull request
Jul 21, 2023
wilkinsona
added a commit
that referenced
this pull request
Jul 21, 2023
Member
|
Thanks, @izeye. I'm not sure if the things that Lettuce supports in the URI are standard or Lettuce-specific. I've found https://www.iana.org/assignments/uri-schemes/prov/redis. It includes the database in the URI but it's only provisional and hasn't been updated since 2015. WDYT, @mp911de? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Javadoc for the
RedisProperties.urlfield to include username in override targets as it seems to override it.A Redis URI seems to be able to include other properties like database, but they are not included in override targets. It seems to be inconsistent, but I'm not sure if it's intentional.