OTel Span is missing required attributes#36155
Closed
jonatan-ivanov wants to merge 1 commit intospring-projects:mainfrom
Closed
OTel Span is missing required attributes#36155jonatan-ivanov wants to merge 1 commit intospring-projects:mainfrom
jonatan-ivanov wants to merge 1 commit intospring-projects:mainfrom
Conversation
OTel semantic conventions mandate certain resource attributes to present on exported spans, see: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/semantic_conventions/README.md#telemetry-sdk I'm not sure why it is so easy or possible removing the mandatory defaults but it seems it is intentional according to the docs/examples, see: https://opentelemetry.io/docs/instrumentation/java/manual/#example
Member
Author
|
I'm not sure |
Member
|
If we're missing some attributes that are mandatory, it sounds like a bug to me. That said, if they're really mandatory, why can they be removed and why doesn't it fail when you do so? |
Member
Author
|
That's my concern too, I don't think it should be possible for users to remove mandatory defaults but the docs disagree, I opened an issue for this: open-telemetry/opentelemetry-java#5595 |
snicoll
pushed a commit
that referenced
this pull request
Jul 17, 2023
OTel semantic conventions mandate certain resource attributes to present on exported spans. This commits make sure that the attribute we add are merged with the defaults, rather than replacing them. See gh-36155
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OTel semantic conventions mandate certain resource attributes to present on exported spans, see telemetry sdk semantic conventions. I'm not sure why it is so easy or possible removing the mandatory defaults but it seems it is intentional according to the docs/examples
Originally opened by @arik-dig: micrometer-metrics/tracing#294