Skip to content

Tracer library HTTP instrumentation is auto-configured unnecessarily#33287

Closed
jonatan-ivanov wants to merge 2 commits into
spring-projects:mainfrom
jonatan-ivanov:tracer-http-support-removal
Closed

Tracer library HTTP instrumentation is auto-configured unnecessarily#33287
jonatan-ivanov wants to merge 2 commits into
spring-projects:mainfrom
jonatan-ivanov:tracer-http-support-removal

Conversation

@jonatan-ivanov

@jonatan-ivanov jonatan-ivanov commented Nov 21, 2022

Copy link
Copy Markdown
Member

Since it was decided that instead of using the tracing libraries (Brave, OTel) HTTP support, we will do something similar instrumentation time, we can remove the auto-configuration for these beans. (cc: @bclozel @marcingrzejszczak)

Slightly connected issue: #33228

@jonatan-ivanov jonatan-ivanov changed the title Tracer librar HTTP instrumentation support removal Tracer library HTTP instrumentation support removal Nov 21, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 21, 2022
@marcingrzejszczak

Copy link
Copy Markdown
Contributor

LGTM!

@wilkinsona wilkinsona changed the title Tracer library HTTP instrumentation support removal Tracer library HTTP instrumentation is auto-configured unnecessarily Nov 22, 2022
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 22, 2022
@wilkinsona wilkinsona added this to the 3.0.0 milestone Nov 22, 2022
@wilkinsona wilkinsona self-assigned this Nov 22, 2022
@jonatan-ivanov jonatan-ivanov deleted the tracer-http-support-removal branch November 22, 2022 22:48
ndwlocatieservices added a commit to ndwnu/nls-accessibility-map that referenced this pull request Aug 19, 2024
…o v3

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [nu.ndw.nls.geometry:nls-geometry](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | major | `2.2.0` -> `3.0.0` |

---

### Release Notes

<details>
<summary>spring-projects/spring-boot (nu.ndw.nls.geometry:nls-geometry)</summary>

### [`v3.0.0`](https://github.com/spring-projects/spring-boot/releases/tag/v3.0.0)

[Compare Source](spring-projects/spring-boot@v2.2.1.RELEASE...v3.0.0)

See the [Release notes for 3.0](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Release-Notes) for upgrade instructions and details of new features.

#### ⭐ New Features

-   Provide a configuration property for the observation patterns of Spring Integration components [#&#8203;33099](spring-projects/spring-boot#33099)

#### 🐞 Bug Fixes

-   io.micrometer.tracing.Tracer on the classpath breaks AOT processing for tests [#&#8203;33298](spring-projects/spring-boot#33298)
-   Tracer library HTTP instrumentation is auto-configured unnecessarily [#&#8203;33287](spring-projects/spring-boot#33287)
-   Auto-configuration ignores user-provided ObservationConventions [#&#8203;33285](spring-projects/spring-boot#33285)
-   `ScheduledBeanLazyInitializationExcludeFilter` is auto-configured even when annotation-based scheduled has not been enabled [#&#8203;33284](spring-projects/spring-boot#33284)
-   SpringBootContextLoader prints banner twice when using a `@ContextHierarchy` [#&#8203;33263](spring-projects/spring-boot#33263)
-   Properties migrator causes an application to fail to start if it tries to map a property whose metadata data entry contains an invalid configuration property name [#&#8203;33250](spring-projects/spring-boot#33250)
-   Wavefront MeterRegistryCustomizer is not applying application tags from application.properties [#&#8203;33244](spring-projects/spring-boot#33244)
-   Actuator responses no longer format timestamps as ISO-8601 [#&#8203;33236](spring-projects/spring-boot#33236)
-   Configuration property is not bound in a native image when property has get, set, and is methods [#&#8203;33232](spring-projects/spring-boot#33232)
-   Configuration property binding does not deal with bridge methods [#&#8203;33212](spring-projects/spring-boot#33212)
-   Contribute missing resource hints for GraphQL schema files and GraphiQL HTML page [#&#8203;33208](spring-projects/spring-boot#33208)
-   Hints for ClientHttpRequestFactory should only be generated for matching methods  [#&#8203;33203](spring-projects/spring-boot#33203)
-...
ndwlocatieservices added a commit to ndwnu/nls-routing-map-matcher that referenced this pull request Aug 21, 2024
…o v3

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [nu.ndw.nls.geometry:nls-geometry](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | major | `2.1.4` -> `3.0.0` |

---

### Release Notes

<details>
<summary>spring-projects/spring-boot (nu.ndw.nls.geometry:nls-geometry)</summary>

### [`v3.0.0`](https://github.com/spring-projects/spring-boot/releases/tag/v3.0.0)

[Compare Source](spring-projects/spring-boot@v2.2.1.RELEASE...v3.0.0)

See the [Release notes for 3.0](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Release-Notes) for upgrade instructions and details of new features.

#### ⭐ New Features

-   Provide a configuration property for the observation patterns of Spring Integration components [#&#8203;33099](spring-projects/spring-boot#33099)

#### 🐞 Bug Fixes

-   io.micrometer.tracing.Tracer on the classpath breaks AOT processing for tests [#&#8203;33298](spring-projects/spring-boot#33298)
-   Tracer library HTTP instrumentation is auto-configured unnecessarily [#&#8203;33287](spring-projects/spring-boot#33287)
-   Auto-configuration ignores user-provided ObservationConventions [#&#8203;33285](spring-projects/spring-boot#33285)
-   `ScheduledBeanLazyInitializationExcludeFilter` is auto-configured even when annotation-based scheduled has not been enabled [#&#8203;33284](spring-projects/spring-boot#33284)
-   SpringBootContextLoader prints banner twice when using a `@ContextHierarchy` [#&#8203;33263](spring-projects/spring-boot#33263)
-   Properties migrator causes an application to fail to start if it tries to map a property whose metadata data entry contains an invalid configuration property name [#&#8203;33250](spring-projects/spring-boot#33250)
-   Wavefront MeterRegistryCustomizer is not applying application tags from application.properties [#&#8203;33244](spring-projects/spring-boot#33244)
-   Actuator responses no longer format timestamps as ISO-8601 [#&#8203;33236](spring-projects/spring-boot#33236)
-   Configuration property is not bound in a native image when property has get, set, and is methods [#&#8203;33232](spring-projects/spring-boot#33232)
-   Configuration property binding does not deal with bridge methods [#&#8203;33212](spring-projects/spring-boot#33212)
-   Contribute missing resource hints for GraphQL schema files and GraphiQL HTML page [#&#8203;33208](spring-projects/spring-boot#33208)
-   Hints for ClientHttpRequestFactory should only be generated for matching methods  [#&#8203;33203](spring-projects/spring-boot#33203)
-...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants