Allow JMX Registration Policy to be set#32573
Closed
mdeinum wants to merge 1 commit intospring-projects:mainfrom
Closed
Allow JMX Registration Policy to be set#32573mdeinum wants to merge 1 commit intospring-projects:mainfrom
mdeinum wants to merge 1 commit intospring-projects:mainfrom
Conversation
Contributor
|
Thank you! |
mhalbritter
pushed a commit
that referenced
this pull request
Jan 31, 2023
izeye
added a commit
to izeye/spring-boot
that referenced
this pull request
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
JmxAutoconfigurationsets theRegistrationPolicytoFAIL_ON_EXISTING. However there can be situations where it might be useful to set it to something else likeIGNORE_EXISTING.This could help to workaround the issue with both HikariCP and Spring Boot registering JMX beans.
See https://stackoverflow.com/questions/73896176/spring-boot-hikari-config-not-loaded/73896695#73896695 (for my recommended solution).
And the issue from HikariCP with several other proposed solutions/workaround.
The drawback of those solutions, imho, is that the disable (or at least partially) the auto-configuration from Spring Boot.