Skip to content

server.servlet.session.cookie.same-site isn't applied to Spring Session's SESSION cookie#28784

Closed
vpavic wants to merge 1 commit into
spring-projects:mainfrom
vpavic:gh-28772
Closed

server.servlet.session.cookie.same-site isn't applied to Spring Session's SESSION cookie#28784
vpavic wants to merge 1 commit into
spring-projects:mainfrom
vpavic:gh-28772

Conversation

@vpavic

@vpavic vpavic commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

This commit adds the mapping of server.servlet.session.cookie.same-site configuration property to DefaultCookieSerializer bean configured in the Spring Session auto-configuration.

See gh-28772

…lizer

This commit adds the mapping of `server.servlet.session.cookie.same-site` configuration property to `DefaultCookieSerializer` bean configured in the Spring Session auto-configuration.

See spring-projectsgh-28772
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 23, 2021
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 29, 2021
@philwebb philwebb added this to the 2.6.x milestone Nov 29, 2021
@snicoll snicoll self-assigned this Dec 9, 2021
@snicoll snicoll modified the milestones: 2.6.x, 2.6.2 Dec 9, 2021
@snicoll snicoll changed the title Apply SameSite session cookie property to Spring Session cookie serializer server.servlet.session.cookie.same-site isn't applied to Spring Session's SESSION cookie Dec 9, 2021
snicoll pushed a commit that referenced this pull request Dec 9, 2021
This commit maps the `server.servlet.session.cookie.same-site`
configuration property to the `DefaultCookieSerializer` bean configured
in the Spring Session auto-configuration.

See gh-28784
@snicoll snicoll closed this in 770e509 Dec 9, 2021
@snicoll

snicoll commented Dec 9, 2021

Copy link
Copy Markdown
Member

Thanks again @vpavic

@vpavic vpavic deleted the gh-28772 branch December 9, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants