Skip to content

Fix SessionAutoConfiguration ordering#11054

Closed
vpavic wants to merge 1 commit intospring-projects:masterfrom
vpavic:reactive-session-mongo
Closed

Fix SessionAutoConfiguration ordering#11054
vpavic wants to merge 1 commit intospring-projects:masterfrom
vpavic:reactive-session-mongo

Conversation

@vpavic
Copy link
Contributor

@vpavic vpavic commented Nov 16, 2017

This PR updates SessionAutoConfiguration to ensure it is processed after MongoDataAutoConfiguration and MongoReactiveDataAutoConfiguration, instead of MongoAutoConfiguration and MongoReactiveAutoConfiguration. This is required in order for MongoDB Session auto-configuration to work, since MongoSessionConfiguration and MongoReactiveSessionConfiguration are conditional on MongoOperations and ReactiveMongoOperations beans, respectively.

This commit updates `SessionAutoConfiguration` to ensure it is processed after `MongoDataAutoConfiguration` and `MongoReactiveDataAutoConfiguration`, instead of `MongoAutoConfiguration` and `MongoReactiveAutoConfiguration`. This is required in order for MongoDB Session auto-configuration to work, since `MongoSessionConfiguration` and `MongoReactiveSessionConfiguration` are conditional on `MongoOperations` and `ReactiveMongoOperations` beans, respectively.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 16, 2017
@philwebb philwebb added priority: normal type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 16, 2017
@philwebb philwebb added this to the 2.0.0.M7 milestone Nov 16, 2017
@philwebb philwebb self-assigned this Nov 16, 2017
@snicoll snicoll self-assigned this Nov 17, 2017
@snicoll snicoll closed this in 44eebca Nov 17, 2017
snicoll added a commit that referenced this pull request Nov 17, 2017
* pr/11054:
  Fix `SessionAutoConfiguration` ordering
@snicoll
Copy link
Member

snicoll commented Nov 17, 2017

Good catch @vpavic!

@vpavic vpavic deleted the reactive-session-mongo branch November 17, 2017 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants