Skip to content

Use Oracle Free rather than Oracle XE with Spring Boot 3.2.0 and later#1352

Closed
gvenzl wants to merge 1 commit intospring-io:mainfrom
gvenzl:main
Closed

Use Oracle Free rather than Oracle XE with Spring Boot 3.2.0 and later#1352
gvenzl wants to merge 1 commit intospring-io:mainfrom
gvenzl:main

Conversation

@gvenzl
Copy link
Contributor

@gvenzl gvenzl commented Nov 17, 2023

Hi Spring team,

This PR upgrades the Testcontainer Oracle module from the Oracle XE module to the new Oracle Free module. Oracle Database Free is the successor of Oracle XE and the Oracle Free docker image as well as the Oracle Free Testcontainers modules are upward compatible.

Also adding @eddumelendez from the TC team.

@gvenzl
Upgrade from Oracle XE to Oracle Free
54ce8f1 
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 17, 2023
@wilkinsona
Copy link
Contributor

wilkinsona commented Nov 17, 2023 •
edited
Loading

We'd missed the XE to Free transition. Thanks for bringing it to our attention, @gvenzl. We'll have to make some changes to Spring Boot before we can merge this:

  • code that looks for gvenzl/oracle-xe to detect the type of the container will have to detect gvenzl/oracle-free as well
  • code that looks for org.testcontainers.containers.OracleContainer will have to look for org.testcontainers.oracle.OracleContainer as well

@wilkinsona
Copy link
Contributor

wilkinsona commented Nov 17, 2023 •
edited
Loading

The Oracle Free module is new in Testcontainers 1.19.2. Spring Boot 3.2 upgraded to Testcontainers 1.19 and it's only 3.2.0 that has upgraded to 1.19.2. This means that the changes proposed here will requires at least Spring Boot 3.2.0 and maybe later depending on the version in which we make the necessary changes on the Boot side. Projects generated with earlier versions will have to continue using Oracle XE.

@gvenzl
Copy link
Contributor Author

gvenzl commented Nov 17, 2023

Hey @wilkinsona,

Of course, thanks a lot for considering this PR!

Fully understand that older versions of Spring Boot will still leverage Oracle XE.
Please let me know if I can be of any further help or if you have any questions.

Thanks,

@philwebb philwebb self-assigned this Nov 21, 2023
@philwebb philwebb removed their assignment Nov 21, 2023
@philwebb philwebb mentioned this pull request Nov 21, 2023
Closed
@eddumelendez
Copy link
Contributor

eddumelendez commented Nov 21, 2023

Hi, this commit added support for the new Oracle Free module in Spring Boot.

@wilkinsona wilkinsona changed the title Upgrade from Oracle XE to Oracle Free Use Oracle Free rather than Oracle XE with Spring Boot 3.2.0 and later Nov 22, 2023
@wilkinsona wilkinsona self-assigned this Nov 22, 2023
wilkinsona pushed a commit that referenced this pull request Nov 24, 2023
@gvenzl @wilkinsona
Use Oracle Free with Spring Boot 3.2 and later
46b964b 
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>

See gh-1352
wilkinsona added a commit that referenced this pull request Nov 24, 2023
@wilkinsona
Polish "Use Oracle Free with Spring Boot 3.2 and later"
caf3dbb 
See gh-1352
@wilkinsona
Copy link
Contributor

wilkinsona commented Nov 24, 2023

Thanks very much, @gvenzl.

@gvenzl
Copy link
Contributor Author

gvenzl commented Nov 24, 2023

And to you, @wilkinsona, for considering and merging it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wilkinsona wilkinsona

Labels

for: merge-with-amendments type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gvenzl @wilkinsona @eddumelendez @philwebb @spring-projects-issues